Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD3 Lora page filter - detection not implemented #16299

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jul 30, 2024

Description

currently when SD3 model is selected Lora page shows all loras as the filter is not implemented
I believe it's mostly due to SD3 Lora it doesn't seem to be a standard of metadata SD3 Lora yet
in the meantime allowing user to manually select the type of lora model is a good idea
but SD3 type also hasn't been added to the lora user metadata


This PR adds

  • SD3 type to Lora user metadat allowing the user to tag the type of the model
  • adding SD3 fiter to Lora page
  • from what I can tell as proper SD3 deduction from metadata hasn't been implemented I've implemented a temporary setting `TEMP_setting_sd3_lora_filter
    • this setting allows other types of model to be also shown when SD3 checkpoint is selected
    • found my observation, SD3 Lora seems to be miss detected as SD1 or Unknow, as such I set SD1 and Unknow to be the default

Checklist:

@w-e-w w-e-w mentioned this pull request Oct 29, 2024
4 tasks
@catboxanon
Copy link
Collaborator

catboxanon commented Oct 29, 2024

proper SD3 deduction from metadata

Has this situation improved within the last several months since this PR was made?

@w-e-w
Copy link
Collaborator Author

w-e-w commented Oct 29, 2024

haven't been paying attention to SD3 lora about how to auto detect

but at least this should allow manual selecting of type
and lay down the groundwork when someone has a proper Auto detection method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants