Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field descriptor test #182

Merged

Conversation

NgChunMan
Copy link
Collaborator

No description provided.

@NgChunMan NgChunMan added this to the v1.3 milestone Oct 29, 2023
@NgChunMan NgChunMan requested a review from NereusWB922 October 29, 2023 14:34
@NgChunMan NgChunMan self-assigned this Oct 29, 2023
@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for tp-preview ready!

Name Link
🔨 Latest commit 68e259a
🔍 Latest deploy log https://app.netlify.com/sites/tp-preview/deploys/654075b33a0b9600093911fc
😎 Deploy Preview https://deploy-preview-182--tp-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #182 (68e259a) into master (b4aed85) will increase coverage by 0.79%.
Report is 1 commits behind head on master.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##             master     #182      +/-   ##
============================================
+ Coverage     54.26%   55.05%   +0.79%     
- Complexity      592      606      +14     
============================================
  Files           119      119              
  Lines          2779     2779              
  Branches        336      336              
============================================
+ Hits           1508     1530      +22     
+ Misses         1075     1049      -26     
- Partials        196      200       +4     
Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
...edu/address/model/field/EditStudentDescriptor.java 85.36% <20.00%> (+41.46%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NgChunMan NgChunMan merged commit 8863fb4 into AY2324S1-CS2103T-W15-2:master Oct 31, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants