Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

184 Update UG #190

Merged
merged 18 commits into from
Nov 2, 2023
Merged

184 Update UG #190

merged 18 commits into from
Nov 2, 2023

Conversation

zannloo
Copy link

@zannloo zannloo commented Oct 30, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for tp-preview ready!

Name Link
🔨 Latest commit a71236c
🔍 Latest deploy log https://app.netlify.com/sites/tp-preview/deploys/654357af31cff90007cff0b9
😎 Deploy Preview https://deploy-preview-190--tp-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #190 (a71236c) into master (93d11ea) will decrease coverage by 0.09%.
Report is 30 commits behind head on master.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
- Coverage     56.60%   56.52%   -0.09%     
- Complexity      648      649       +1     
============================================
  Files           118      118              
  Lines          2959     2967       +8     
  Branches        362      362              
============================================
+ Hits           1675     1677       +2     
- Misses         1068     1071       +3     
- Partials        216      219       +3     
Files Coverage Δ
src/main/java/seedu/address/Main.java 0.00% <ø> (ø)
...address/logic/commands/ChangeDirectoryCommand.java 0.00% <ø> (ø)
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <ø> (ø)
...edu/address/logic/commands/CreateGroupCommand.java 84.84% <100.00%> (ø)
...u/address/logic/commands/CreateStudentCommand.java 75.67% <ø> (ø)
...ic/commands/DeleteForStudentsAndGroupsCommand.java 71.42% <ø> (ø)
...eedu/address/logic/commands/DeleteTaskCommand.java 81.08% <100.00%> (ø)
...java/seedu/address/logic/commands/EditCommand.java 53.33% <ø> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <ø> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <ø> (ø)
... and 12 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Loo Mei Lin Zann added 15 commits October 30, 2023 19:58
…e-ug

* 'master' of https://github.com/zannloo/tp: (33 commits)
  Fix test cases
  Fix checkstyle error
  Allow create task to allStu for root directory
  Refactor to use enum Category
  Create Category enum
  Check duplicate task for bulk task assignment
  Check duplicate task for all children
  Refactor test cases
  Email should be lower case
  Add more checks
  Add isAnyFieldEdited missing check
  Make it case insensitive
  Edit message
  Fix bug in creating new entity
  Add method to get entity with given id
  Edit message format
  Add methods to check existance of id in ProfBook
  Add test cases
  Fix bug in constructor with empty data
  Add constructors with empty model data
  ...
…e-ug

* 'master' of https://github.com/zannloo/tp: (29 commits)
  Add help option
  Fix checkstyle issue
  Fix checkstyle issue
  Add test for EditCommandTest class
  Add test for EditCommandTest class
  Update name of test
  Add test case for DeleteForStudentsAndGroupsCommandTest class
  Add test case for CreateGroupCommandTest class
  Add test case for CreateGroupCommandTest class
  Add test case to CreateDeadlineCommandTest class
  Add test case to CreateTodoCommandTest class
  Edit error message
  Fix test cases
  Fix checkstyle error
  Check options are valid before tokenize
  Check if all options given are valid
  Fix bug
  Add util to check options in argString are valid
  Add methods for option checking
  Add test to test toString methods
  ...
…e-ug

* 'master' of https://github.com/zannloo/tp: (34 commits)
  Refactor with new interface
  Refactor with new ReadOnlyTaskList
  Implement IChildrenManager
  Implement ITaskListManager
  Refactor with new ReadOnlyTaskList
  Refactor with new interfaces
  Change ReadOnlyTaskList to interface
  Add interface for ChildrenManager
  Add interface for TaskListManager
  Change set to list
  Sort before getAllChildren
  Implement Comparator
  Update message usage
  Update message usage
  Update message usage
  Update message usage
  Update message usage for every command
  Standardise message usage for every command
  Remove test case
  Standardise the message usage for every command
  ...
NereusWB922
NereusWB922 previously approved these changes Nov 2, 2023
Copy link
Collaborator

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zannloo zannloo merged commit 6327c57 into AY2324S1-CS2103T-W15-2:master Nov 2, 2023
@zannloo zannloo linked an issue Nov 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UG
2 participants