Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs: Check duplicate task #193

Conversation

NereusWB922
Copy link
Collaborator

  • Check duplicate task for bulk task assignment
  • Allow assign task for all students under root

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for tp-preview ready!

Name Link
🔨 Latest commit b4aed85
🔍 Latest deploy log https://app.netlify.com/sites/tp-preview/deploys/653f962c5333b30007a948dd
😎 Deploy Preview https://deploy-preview-193--tp-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NereusWB922 NereusWB922 requested a review from a team October 30, 2023 11:40
@NereusWB922 NereusWB922 self-assigned this Oct 30, 2023
@NereusWB922 NereusWB922 added this to the v1.3 milestone Oct 30, 2023
@NereusWB922 NereusWB922 linked an issue Oct 30, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #193 (b4aed85) into master (3d069be) will decrease coverage by 1.12%.
Report is 1 commits behind head on master.
The diff coverage is 41.25%.

@@             Coverage Diff              @@
##             master     #193      +/-   ##
============================================
- Coverage     55.37%   54.26%   -1.12%     
- Complexity      577      592      +15     
============================================
  Files           118      119       +1     
  Lines          2707     2779      +72     
  Branches        308      336      +28     
============================================
+ Hits           1499     1508       +9     
- Misses         1036     1075      +39     
- Partials        172      196      +24     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 78.26% <ø> (ø)
...in/java/seedu/address/logic/commands/Category.java 100.00% <100.00%> (ø)
...ress/logic/parser/CreateDeadlineCommandParser.java 73.68% <100.00%> (ø)
.../address/logic/parser/CreateTodoCommandParser.java 72.22% <100.00%> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 67.60% <20.00%> (-1.96%) ⬇️
.../address/logic/commands/CreateDeadlineCommand.java 50.76% <35.89%> (-25.83%) ⬇️
...eedu/address/logic/commands/CreateTodoCommand.java 52.38% <39.02%> (-31.34%) ⬇️
.../main/java/seedu/address/model/ChildOperation.java 52.87% <40.00%> (-6.78%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@NgChunMan NgChunMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is essential to ensure there are no tasks added twice to a student.

@NereusWB922 NereusWB922 merged commit bfc5e4b into AY2324S1-CS2103T-W15-2:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug: never check duplicate task for bulk task assignment
2 participants