Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application crash when input //// as path #310

Merged

Conversation

NereusWB922
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for tp-preview ready!

Name Link
🔨 Latest commit f90c686
🔍 Latest deploy log https://app.netlify.com/sites/tp-preview/deploys/6551da2817c8020008d9f20b
😎 Deploy Preview https://deploy-preview-310--tp-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #310 (f90c686) into master (84f82f6) will increase coverage by 0.18%.
Report is 30 commits behind head on master.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #310      +/-   ##
============================================
+ Coverage     78.31%   78.49%   +0.18%     
- Complexity      937      939       +2     
============================================
  Files           116      116              
  Lines          3011     3055      +44     
  Branches        363      364       +1     
============================================
+ Hits           2358     2398      +40     
- Misses          484      488       +4     
  Partials        169      169              
Files Coverage Δ
...in/java/seedu/address/model/path/RelativePath.java 88.23% <100.00%> (ø)
src/main/java/seedu/address/model/path/Path.java 90.16% <60.00%> (+0.33%) ⬆️

... and 11 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@NereusWB922 NereusWB922 requested a review from a team November 13, 2023 08:13
Copy link
Collaborator

@Nid21cs Nid21cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@NgChunMan NgChunMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NereusWB922 NereusWB922 merged commit a589ae9 into AY2324S1-CS2103T-W15-2:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants