Update manual test cases for dg #367
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
docs/DeveloperGuide.md
Outdated
|
|
||
| 1. Other incorrect delete commands to try: `delete`, `delete x`, `...` (where x is larger than the list size)<br> | ||
| 1. Add a person by to KonTActs |
There was a problem hiding this comment.
Just a small grammar error, remove the word "by"
docs/DeveloperGuide.md
Outdated
| 3. Test case: `addgrade/John Doe a/Ex05 s/5` <br> | ||
| Expected: No grade is added to John Doe. Details of the error message is shown in the status message. | ||
|
|
||
| 4. Other incorrect add grade commands to try: `addgrade`, `addgrade s/x` (where `x` is not a number)<br> |
There was a problem hiding this comment.
Maybe could paraphrase the part in brackets to : where 'x' is not a number or 'x' is bigger than the max value of the assignment.
docs/DeveloperGuide.md
Outdated
| 1. Remove grade from a person | ||
| 1. Prerequisites: Contact `John Doe` with grades(assignment name,score) `Ex01,5` and `Ex02,3` added. | ||
|
|
||
| 2. Test case: `removegrade n/John Doe a/Ex01` <br> |
There was a problem hiding this comment.
It should be removeGrade instead of removegrade.
docs/DeveloperGuide.md
Outdated
| 2. Test case: `removegrade n/John Doe a/Ex01` <br> | ||
| Expected: Assignment `Ex01` is removed from `John Doe`. Details shown in the status message. | ||
|
|
||
| 3. Test case: `removegrade/John Doe a/Ex05 s/5` <br> |
There was a problem hiding this comment.
Similar to comment on line 693.
docs/DeveloperGuide.md
Outdated
| 3. Test case: `removegrade/John Doe a/Ex05 s/5` <br> | ||
| Expected: No grade is removed from John Doe. Details of the error message is shown in the status message. | ||
|
|
||
| 4. Other incorrect remove grade commands to try: `removegrade`, `removegrade a/x` (where `x` is any value)<br> |
There was a problem hiding this comment.
Similar to comment on line 693.
docs/DeveloperGuide.md
Outdated
| Expected: `John Doe` is marked as present for week 5. Details of the marked week is shown in status message and the list. | ||
|
|
||
| 2. Test case: `mark n/John Doe w/s` <br> | ||
| Expected: No attendance is marked for `John Doe`. Details of the error is shown in the status message. |
There was a problem hiding this comment.
The expected outcome seems confusing. We could probably say "Attendance would not be remarked for the same person and same week".
docs/DeveloperGuide.md
Outdated
| Expected: `John Doe` is marked as absent for week 5. Details of the unmarked week is shown in status message and the list. | ||
|
|
||
| 2. Test case: `unmark n/John Doe w/s` <br> | ||
| Expected: No attendance is unmarked for `John Doe`. |
There was a problem hiding this comment.
Similar to comment on line 708.
docs/DeveloperGuide.md
Outdated
| 2. Test case: `view n/` | ||
| Expected: No view window appears. Details of error shown in status message. | ||
|
|
||
| 3. Other incorrect view commands to try: `view`, `view n` |
There was a problem hiding this comment.
just typing view is not an incorrect command since it closes the viewWindow. Maybe we can remove view from the list of incorrect view commands?
Closes #340