Update use cases to match implementation #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
docs/DeveloperGuide.md
Outdated
| - Steps 3a1 - 3a2 are repeated until input format is correct. | ||
| - 1a1.KonTActs rejects the addition request and shows an error message. | ||
| - 1b2. User enters a new input. | ||
| - Steps 1a1 - 3a1 are repeated until input entered is correct. |
There was a problem hiding this comment.
This should be '1a2' and not '3a1'
docs/DeveloperGuide.md
Outdated
| - 3b2. User enters a new input. | ||
| - Steps 3a1 - 3a2 are repeated until input format is correct. | ||
| - 1a1.KonTActs rejects the addition request and shows an error message. | ||
| - 1b2. User enters a new input. |
There was a problem hiding this comment.
This should be '1a2' and not '1b2'
docs/DeveloperGuide.md
Outdated
|
|
||
| Use case resumes from step 4. | ||
| Use case resumes from step 1. |
There was a problem hiding this comment.
I feel this should be step 2 instead similar to line 308
docs/DeveloperGuide.md
Outdated
|
|
||
| Use case ends. | ||
|
|
||
| **Extensions** | ||
|
|
||
| - 2a. KonTActs detects an unsupported, corrupted file or a file without the valid headers. | ||
| - 1a. KonTActs detects the file provided is invalid. | ||
|
|
||
| - 2a1. KonTActs indicates it is unable to import from that file and gives a more specific error message. |
There was a problem hiding this comment.
This needs to be changed to '1a1' and '1a2'
docs/DeveloperGuide.md
Outdated
|
|
||
| - 2a1. KonTActs indicates it is unable to import from that file and gives a more specific error message. | ||
| - 2a2. User provides a new file path | ||
| - Steps 2a1 - 2a2 are repeated until KonTActs is able to import contacts from the file. | ||
|
|
||
| Use case resumes from step 3. | ||
|
|
||
| - 2b. KonTActs detects invalid content in CSV file (e.g. Name/Email that does not comply with requirement, | ||
| Duplicate names) | ||
| - 1b. KonTActs detects invalid content in CSV file. | ||
|
|
||
| - 2b1. KonTActs indicates it is unable to import from that file and gives a more specific error message. |
There was a problem hiding this comment.
This needs to be changed to '2b1' to '2b2'
Incogdino
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369