This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
refactor commands #320
Merged
refactor commands #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakethekoenig
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
One idea to avoid needing to import is to change the strange pattern where the commands register themselves when they're defined. We could do something similar to what we do for parsers:
- Have an abstract command class with
apply/argument_names/help_message. (like we do now without the class methods) - Have a dictionary mapping names to commands.
Approving because I think this is directionaly an improvement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors each command into a separate file. I don't like that we have to import each command in command/commands/init.py; feel free to suggest any better ideas.