Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark GamesServices class and methods as deprecated #131

Closed
wants to merge 0 commits into from

Conversation

theLee3
Copy link
Collaborator

@theLee3 theLee3 commented Dec 2, 2023

Marks deprecated and guides devs to the specialized classes. This will encourage devs to migrate so we can remove in a future version.

@theLee3 theLee3 deleted the branch Abedalkareem:develop January 3, 2024 04:47
@theLee3 theLee3 closed this Jan 3, 2024
@theLee3 theLee3 deleted the develop branch January 3, 2024 04:47
@theLee3 theLee3 restored the develop branch January 3, 2024 04:47
@theLee3 theLee3 reopened this Jan 3, 2024
@Abedalkareem
Copy link
Owner

Hi,
Sorry for the late reply, The last month was really busy at work and home 🥹.

I think let's not do this move now because a lot of tutorials is using the old one and I don't think there is a harm in doing that, like this official flutter tutorial

https://docs.flutter.dev/cookbook/games/achievements-leaderboard

@theLee3
Copy link
Collaborator Author

theLee3 commented Jan 8, 2024

No worries. Hope all is well.

I understand your point, but that is exactly why I think we should mark it as deprecated. We leave it in so that it still works, but it would encourage devs to use the new approach. The comments provided will allow the IDE to point the dev to the new classes & methods for achieving the same results as well.

I, of course, defer to you, but it's not uncommon for a package to have something marked as deprecated for many versions before removing it, so there is no rush to do so once marked.

As an added note, Dart's deprecated annotation allows us to set a timeline to show in IDE messages that gives devs information about when things will be removed, if we happen to set a date/version to sunset the GamesServices class in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants