loadPlayerScoreObject for rank retrieval, and other enhancements #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GetPlayerScoreObject to retrieve rank and other score data for leaderboard / time span - Added optional String 'token' to score, to store additional score info/metadata. Saved as scoreTag (String) on Android, context (Int) on iOS - Added optional showsCompletionBanner as parameter for report achievement, replace hard-coded true, default true - Added resetAchievements, iOS only, Android doesn't support - Update play-services-games - Update play-services-auth
|
Thanks @egonbeermat. Some cool contributions here. I will look through the code asap. |
|
@theLee3 Did you get a chance to review these changes yet? |
|
@egonbeermat I am so sorry, I have not. I will make it a priority over the next few days. |
|
Can you please fix the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user requested the ability to retrieve a players score rank. I had previously modified this package locally to add methods to do that, and it has been live for almost a year in my app. I have modified my local update to incorporate the latest change to use
PlayerDataand am offering up the code here (plus some other enhancements) for you to pull apart, change and incorporate if you wish! Details below:getPlayerScoreObjectto retrieve rank and other score data for leaderboard and time spantokento methods that submit and retrieve score. Can be used to store additional information or metadata about the score. Saved asscoreTag(String) on Android,context(Int) on iOS. Due to the difference in datatype between Android / iOS, I decided that while Int was 'safer' as the type (compatible with both), String offers more for Android-only implementations, and a documented note for iOS users to use Int that was converted to String on submission would sufficeshowsCompletionBanneras parameter for iOSGKAchievement.report, replacing hard-coded true. Defaults to trueresetAchievementsmethod for iOS only, Android doesn't support this through Play Games