Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional forceRefresh parameters to load methods on Android. #173

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

theLee3
Copy link
Collaborator

@theLee3 theLee3 commented Aug 14, 2024

As per the docs, regarding forceReload:

If true, this call will clear any locally cached data and attempt to fetch the latest data from the server. This would commonly be used for something like a user-initiated refresh. Normally, this should be set to false to gain advantages of data caching.

Currently, we provide no forceReload option for leaderboards, causing outdated data from the cache to be returned at times. We also always force reload data for both achievements & saved games. As noted in the docs, this should not be the default. Therefore, we should defer to the devs to select the appropriate call for all of these methods.

This has no effect on iOS/MacOS as there is no caching mechanism to invalidate.

@theLee3 theLee3 requested a review from Abedalkareem August 14, 2024 19:56
@PacifistaBot
Copy link
Collaborator

PacifistaBot commented Aug 14, 2024

Fails
🚫 Flutter analyzer failed. Please fix the issues reported by the analyzer. Error: Command failed: flutter analyze 1 issue found. (ran in 7.3s)
Warnings
⚠️

Please update the CHANGELOG.md file.

Generated by 🚫 dangerJS against 0a63a77

@theLee3
Copy link
Collaborator Author

theLee3 commented Aug 14, 2024

Just updated the docs as well in this PR.

@theLee3 theLee3 force-pushed the feature/optional_force_reload_android branch from 79c5677 to 0a63a77 Compare August 15, 2024 04:38
@Abedalkareem Abedalkareem merged commit af40ad5 into develop Aug 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants