Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt w.r.t. coq/coq#19343. #515

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

ppedrot
Copy link
Contributor

@ppedrot ppedrot commented Jul 11, 2024

Should be backwards compatible.

@xavierleroy
Copy link
Contributor

Thanks for the patch. It seems to be about extraction, while coq/coq#19343 is about functional induction. Could you tell us more?

@proux01
Copy link
Contributor

proux01 commented Jul 15, 2024

coq/coq#19343 removes the dependency of stdlib's MSetAVL on FunInd which is itself requiring Extraction.
It appears Compcert was relying on this transitive requirement, the current pull request just makes that requirement explicit.

@xavierleroy
Copy link
Contributor

Crystal clear! Thanks for the explanation.

@xavierleroy xavierleroy merged commit 72c6a18 into AbsInt:master Jul 15, 2024
7 checks passed
@xavierleroy
Copy link
Contributor

I think that in the long run Menhir itself should generate the Require Extraction directive. https://gitlab.inria.fr/fpottier/menhir/-/issues/75

@ppedrot ppedrot deleted the rm-funind-msetavl branch July 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants