Skip to content

Commit

Permalink
* typo fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
benedeki committed May 27, 2024
1 parent 2d3c015 commit 39e52f4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/jacoco_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,23 +64,21 @@ jobs:
id: jacoco-model
uses: madrapps/[email protected]
with:
name: model-jacoco-report
paths: ${{ github.workspace }}/model/target/jvm-${{ env.scalaShort }}/jacoco/report/jacoco.xml
token: ${{ secrets.GITHUB_TOKEN }}
min-coverage-overall: ${{ env.overall }}
min-coverage-changed-file: ${{ env.changed }}
min-coverage-changed-files: ${{ env.changed }}
title: JaCoCo model module code coverage report - scala ${{ env.scalaLong }}
update-comment: true
- name: Add coverage to PR (agent)
if: steps.jacocorun.outcome == 'success'
id: jacoco-agent
uses: madrapps/[email protected]
with:
name: agent-jacoco-report
paths: ${{ github.workspace }}/agent/target/spark3-jvm-${{ env.scalaShort }}/jacoco/report/jacoco.xml
token: ${{ secrets.GITHUB_TOKEN }}
min-coverage-overall: ${{ env.overall }}
min-coverage-changed-file: ${{ env.changed }}
min-coverage-changed-files: ${{ env.changed }}
title: JaCoCo agent module code coverage report - scala ${{ env.scalaLong }}
update-comment: true
- name: Add coverage to PR (server)
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ It provides functionality for computing and pushing control metrics to the API l
For more information, see the [Vocabulary section](#Vocabulary) or `agent/README.md` for more technical documentation.

#### Spark 2.4 support
Because there are some java level incompatibilities between Spark 2.4 and Spark 3.x whe build on Java 11+, we have to
Because there are some java level incompatibilities between Spark 2.4 and Spark 3.x when build on Java 11+, we have to
drop support for Spark 2.4. If you need the agent to work with Spark 2.4 follow these steps:
* Switch to Java 8
* In `'build.sbt'` change the matrix rows, to be Spark 2.4 and Scala 2.11 for modules _agent_ and _model_
Expand Down Expand Up @@ -127,7 +127,7 @@ executing the calculation against a given Spark DataFrame.
Some `Measures` define no columns (such as `count`), some require exactly one column (such as `sum` of values for
particular column), and some require more columns (such as `hash` function).

### Measurement
### Measurement

Practically speaking, a single `Measurement` contains a `Measure` and result associated with it.

Expand Down

0 comments on commit 39e52f4

Please sign in to comment.