#23: normalizing Scala -> PG objects #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsulak
requested review from
benedeki,
TebaleloS,
Zejnilovic,
dk1844 and
salamonpavel
as code owners
JaCoCo agent module code coverage report - spark:2 - scala 2.12.12
|
JaCoCo server module code coverage report - scala 2.12.12
|
benedeki
reviewed
Nov 7, 2023
| } | ||
|
|
||
| private def scalaSeqToPgArray(toConvert: Seq[String]): String = { | ||
| val scalaArrayAndItsContent: Regex = "^\\[(.*)\\]$".r |
There was a problem hiding this comment.
Please add a comment what the Regex matches.
Also I have a suspicion, it might not be correct. 😟
|
|
||
| private def scalaSeqToPgArray(toConvert: Seq[String]): String = { | ||
| val scalaArrayAndItsContent: Regex = "^\\[(.*)\\]$".r | ||
| val scalaSeqJsonized = SerializationUtils.asJson(toConvert) |
There was a problem hiding this comment.
"Jsonizing" any string? Do we really want/need that? 🤔
There was a problem hiding this comment.
Explained via a quick chat
benedeki
previously approved these changes
Nov 8, 2023
Comment on lines
46
to
47
| val scalaSeqJsonized = SerializationUtils.asJson(toConvert) // this also correctly escapes double quotes | ||
| "{" + scalaSeqJsonized.substring(1, scalaSeqJsonized.length - 1) + "}" |
There was a problem hiding this comment.
Minor:
Suggested change
| val scalaSeqJsonized = SerializationUtils.asJson(toConvert) // this also correctly escapes double quotes | |
| "{" + scalaSeqJsonized.substring(1, scalaSeqJsonized.length - 1) + "}" | |
| val scalaSeqJsonized = SerializationUtils.asJson(toConvert) // this also correctly escapes double quotes | |
| "{" + scalaSeqJsonized.substring(1, scalaSeqJsonized.length - 1) + "}" //...only the square brackets have to be replaced with curly ones |
There was a problem hiding this comment.
That's better, thanks, I'll change it :)
benedeki
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23, but won't fully implement everything in that ticket. I'll split it into more PRs because #23 is dependant on DB code that is still not fully done&merged.