Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#52: Call SaveCheckpoint REST API endpoint #125

Merged
merged 7 commits into from
Nov 17, 2023
Merged

#52: Call SaveCheckpoint REST API endpoint #125

merged 7 commits into from
Nov 17, 2023

Conversation

benedeki
Copy link
Contributor

  • implemented the HttpDispatcher.saveCheckpoint
  • introduce a new AtumAgentException
  • structured the AtumAgentException and descendants a little

Closes #52

@benedeki
#52: Call SaveCheckpoint REST API endpoint
9018661 
* initial commit
@benedeki
* implemented the HttpDispatcher.saveCheckpoint
4e5c11e 
* introduce a new `AtumAgentException`
* structured the `AtumAgentException` and descendants a little
@benedeki
Copy link
Contributor Author

Needs e2e testing but code-wise I think it's done.

@benedeki benedeki self-assigned this Nov 16, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

JaCoCo agent module code coverage report - spark:2 - scala 2.12.18

File Coverage [67.74%] ❌
AtumContext.scala 97.07% 🍏
Measurement.scala 86.78% 🍏
MeasuresBuilder.scala 84.38% 🍏
AtumAgentException.scala 56.41% ❌
HttpDispatcher.scala 0% ❌
Total Project Coverage 76.7% ❌

@github-actions GitHub Actions
Copy link

JaCoCo server module code coverage report - scala 2.12.18

There is no coverage information present for the Files changed

Total Project Coverage 18.71% ❌

@benedeki
* limit log noise
61afe28
@benedeki
* changed timestamp format pattern to work with server
0b51093 
* included `json4sCore` library instead of provided
* included `json4sJackson` library instead of provided
* fixes
@benedeki
* replaced OffsetDateTime with ZonedDateTime
cd600d5 
* decreased test log size
@benedeki
* fixes
1897597
@benedeki
* PR comments addressed
d09044b 
* swapped actual and expected in `SerializationUtilsTest.scala`
Zejnilovic
Zejnilovic approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Zejnilovic Zejnilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code. Attended the dev sessions.

@benedeki benedeki merged commit 73efbcb into master Nov 17, 2023
@benedeki benedeki deleted the feature/52-call-savecheckpoint-rest-api-endpoint branch November 17, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zejnilovic Zejnilovic Zejnilovic approved these changes

@lsulak lsulak Awaiting requested review from lsulak lsulak is a code owner

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees

@benedeki benedeki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call SaveCheckpoint REST API endpoint
2 participants
@benedeki @Zejnilovic