response envelope #199
Merged
response envelope #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo server module code coverage report - scala 2.13.11
|
salamonpavel
requested review from
benedeki,
lsulak,
TebaleloS,
Zejnilovic and
dk1844
as code owners
…e-envelope # Conflicts: # server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerIntegrationTests.scala
lsulak
reviewed
May 24, 2024
server/src/main/scala/za/co/absa/atum/server/model/PlayJsonImplicits.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
May 24, 2024
...src/test/scala/za/co/absa/atum/server/api/http/CreateCheckpointEndpointIntegrationTest.scala
Show resolved
Hide resolved
lsulak
reviewed
May 24, 2024
server/src/main/scala/za/co/absa/atum/server/model/SuccessResponse.scala
Show resolved
Hide resolved
lsulak
reviewed
May 24, 2024
| apiV1.post | ||
| .in(CreateCheckpoint) | ||
| .in(jsonBody[CheckpointDTO]) | ||
| .out(statusCode(StatusCode.Created)) | ||
| .out(jsonBody[CheckpointDTO]) | ||
| .out(jsonBody[SingleSuccessResponse[CheckpointDTO]]) |
There was a problem hiding this comment.
actually I don't know if we want to do this - for potential compatibility reasons
There was a problem hiding this comment.
let's talk about it on the internal MS chat
TebaleloS
previously approved these changes
May 27, 2024
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
lsulak
reviewed
May 27, 2024
server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala
Outdated
Show resolved
Hide resolved
|
So probably the only thing now we have to do (after this PR, I'd say) is to make the agent compatible with v2 APIs. And also using circe for SerDe fully/everywhere, instead of the current approach. |
|
Release notes
|
lsulak
previously approved these changes
Jun 12, 2024
# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/CheckpointController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/http/BaseEndpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Endpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Routes.scala # server/src/main/scala/za/co/absa/atum/server/model/PlayJsonImplicits.scala
lsulak
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces envelopes for API responses.
Closes #197
Release notes: