Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#217: JaCoCo Report workflow is not checking server module coverage #218

Merged
merged 1 commit into from
Jun 27, 2024
Merged

#217: JaCoCo Report workflow is not checking server module coverage #218

merged 1 commit into from
Jun 27, 2024

Conversation

benedeki
Copy link
Contributor

  • added check on server coverage
  • added optional check on overall coverage of modules
  • rename of some variables

Closes #217

@benedeki
#217: JaCoCo Report workflow is not checking server module coverage
ca0ef8a 
* added check on server coverage
* added optional check on overall coverage of modules
* rename of some variables
@benedeki benedeki requested a review from miroslavpojer June 27, 2024 05:16
@benedeki benedeki added the no RN No release notes required label Jun 27, 2024
@github-actions GitHub Actions
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 60.74% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 86.35% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 64.04% 🍏

There is no coverage information present for the Files changed

miroslavpojer
miroslavpojer approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last idea: How about overall values per module?

@benedeki
Copy link
Contributor Author

Last idea: How about overall values per module?

This is already a long workflow, with a proclivity for typo errors or omitting stuff (like modules).
A creation of dedicated action is the way to go forward.

TebaleloS
TebaleloS approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@TebaleloS TebaleloS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable %.

@benedeki benedeki added no RN No release notes required and removed no RN No release notes required labels Jun 27, 2024
@benedeki benedeki merged commit dcefb8c into master Jun 27, 2024
11 of 13 checks passed
@benedeki benedeki deleted the bugfix/217-jacoco-report-workflow-is-not-checking-server-module-coverage branch June 27, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@TebaleloS TebaleloS TebaleloS approved these changes

@salamonpavel salamonpavel salamonpavel approved these changes

@lsulak lsulak lsulak approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

Assignees
No one assigned
Labels
no RN No release notes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JaCoCo Report workflow is not checking server module coverage
5 participants
@benedeki @lsulak @salamonpavel @TebaleloS @miroslavpojer