get partitioning endpoint v2 implementation #226: #240

TebaleloS · 2024-08-06T10:13:01Z

Release notes:

Define and implemented PL/PG SQL function to retrieve partitioning by id.
Implement the endpoint functionality to retrieve partitioning by id.
Added Unit and integration tests.

Closes #226

…OneOfVariant methods

TebaleloS · 2024-08-06T10:16:49Z

Release notes:

Get partitioning endpoint implementation.

…o feature/#226-get-partitioning-endpoint-V2-implementation # Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/http/BaseEndpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Endpoints.scala

…implementation # Conflicts: # server/src/main/scala/za/co/absa/atum/server/Main.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/BaseController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/CheckpointController.scala # server/src/main/scala/za/co/absa/atum/server/api/controller/CheckpointControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/database/runs/functions/WriteCheckpointV2.scala # server/src/main/scala/za/co/absa/atum/server/api/exception/AppError.scala # server/src/main/scala/za/co/absa/atum/server/api/http/BaseEndpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Endpoints.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/BaseRepository.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepository.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/BaseService.scala # server/src/main/scala/za/co/absa/atum/server/api/service/CheckpointService.scala # server/src/main/scala/za/co/absa/atum/server/api/service/CheckpointServiceImpl.scala # server/src/main/scala/za/co/absa/atum/server/model/CheckpointFromDB.scala # server/src/test/scala/za/co/absa/atum/server/api/TestData.scala # server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/controller/PartitioningControllerUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/database/runs/functions/WriteCheckpointV2IntegrationTests.scala # server/src/test/scala/za/co/absa/atum/server/api/http/PostCheckpointEndpointV2UnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/service/CheckpointServiceUnitTests.scala # server/src/test/scala/za/co/absa/atum/server/api/service/PartitioningServiceUnitTests.scala

github-actions · 2024-08-23T11:33:12Z

JaCoCo model module code coverage report - scala 2.13.11

Overall Project	63.64%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-08-23T11:33:13Z

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project	85.84%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-08-23T11:33:14Z

JaCoCo server module code coverage report - scala 2.13.11

Overall Project	75.95% `-8.99%`	🍏
Files changed	70.65%	❌

File	Coverage
PartitioningFromDB.scala	100% `-1364.29%`	❌
PartitioningServiceImpl.scala	100%	🍏
BaseController.scala	100%	🍏
PartitioningControllerImpl.scala	92.21%	🍏
PartitioningRepositoryImpl.scala	85.95%	🍏
GetPartitioningById.scala	42.9% `-91.09%`	❌

salamonpavel · 2024-08-26T10:38:50Z

...r/src/test/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryUnitTests.scala

 import za.co.absa.db.fadb.status.{FunctionStatus, Row}
 import zio._
 import zio.interop.catz.asyncInstance
 import zio.test.Assertion.failsWithA
-import zio.test._
+import zio.test.{assertZIO, _}


import zio.test._

benedeki · 2024-08-28T15:33:03Z

server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala

+    mapToSingleSuccessResponse(
+      serviceCall[PartitioningWithIdDTO, PartitioningWithIdDTO](
+        partitioningService.getPartitioning(partitioningId),
+        identity


Small:
Can be omitted, as identity is now default.

…implementation

github-actions · 2024-08-28T16:31:06Z

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project	100%	🍏

There is no coverage information present for the Files changed

benedeki · 2024-08-29T10:11:39Z

The failing test coverage has bee investigated. It's caused by inaccurate measuring by JaCoco. Nothing to do about it now.

salamonpavel and others added 8 commits August 5, 2024 13:58

postCheckpointEndpointV2

682354e

Defining and implementing getPartitioningEndpointV2 and notFoundError…

9c22eac

…OneOfVariant methods

defining abstract methods and route

8f7d1fd

postCheckpointV2

b72ebfa

write_checkpoint_v2

7b7819c

fix existing tests

b4604c4

fixes related to error model

4b89a3a

creating get_partitioning_by_id db function

86919fa

TebaleloS self-assigned this Aug 6, 2024

TebaleloS added Server Issues touching the server part of the project work in progress Work on this item is not yet finished (mainly intended for PRs) labels Aug 6, 2024

salamonpavel and others added 18 commits August 6, 2024 13:01

fixes related to error model

47dea31

param name fix

cc4af62

exceptions imports

bb6331e

exceptions imports

19e6382

creating GetPartitioningById class

ee434e3

PostCheckpointEndpointV2UnitTests

a3ffb44

fixing the db function and some classes

1b29c05

adding NotFoundDatabaseError

18d51fb

Changing func to proper signatures and add use NotFoundException

26f107b

Adding layer in main

1e54eb7

Adding license

842f6c8

Adding license

c556bab

Modifying SQL function

b81ae68

tests

928823d

tests

bf47223

remove unused import

c4245eb

Modifying SQL function and adding integration testing

eb66639

TebaleloS added 3 commits August 16, 2024 14:45

Addressing GitHub Comments

b89a0a0

Reverting changes in the repository

dfe2b29

getPartitioningV2 endpoint unit test

fe67d81

TebaleloS removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Aug 20, 2024

Base automatically changed from feature/232-post-checkpoint to master August 21, 2024 06:19

TebaleloS added 8 commits August 22, 2024 08:57

implementing endpoint test case

07b0b24

fixing endpoint test case

95b9fee

Closes #226

a38239f

using latest declaration in uuid

9e00744

Removing writeCheckpointV2 duplicating file

f55e114

Restoring writeCheckpointV2 duplicating file

11f5f89

Refactoring write_checkpointV2 from V1.9.2 to V1.9.5

4e83d45

TebaleloS added 2 commits August 26, 2024 08:54

Refactoring test files

55a5242

Removing outdated files

5200224

salamonpavel reviewed Aug 26, 2024

View reviewed changes

TebaleloS added 2 commits August 26, 2024 15:02

Addressing GitHub comments

3c34522

merge master

f559e27

benedeki reviewed Aug 28, 2024

View reviewed changes

benedeki previously approved these changes Aug 28, 2024

View reviewed changes

removing identity

f2e9a16

TebaleloS dismissed benedeki’s stale review via f2e9a16 August 28, 2024 16:23

Merge branch 'master' into feature/#226-get-partitioning-endpoint-V2-…

8abcc86

…implementation

benedeki merged commit 48a7a32 into master Aug 30, 2024
9 of 10 checks passed

benedeki deleted the feature/#226-get-partitioning-endpoint-V2-implementation branch August 30, 2024 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

get partitioning endpoint v2 implementation #226: #240

get partitioning endpoint v2 implementation #226: #240

TebaleloS commented Aug 6, 2024 •

edited by miroslavpojer

Loading

TebaleloS commented Aug 6, 2024

github-actions bot commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024

github-actions bot commented Aug 23, 2024 •

edited

Loading

salamonpavel Aug 26, 2024

benedeki Aug 28, 2024

github-actions bot commented Aug 28, 2024

benedeki commented Aug 29, 2024

get partitioning endpoint v2 implementation #226: #240

get partitioning endpoint v2 implementation #226: #240

Conversation

TebaleloS commented Aug 6, 2024 • edited by miroslavpojer Loading

TebaleloS commented Aug 6, 2024

Get partitioning endpoint implementation.

github-actions bot commented Aug 23, 2024 • edited Loading

JaCoCo model module code coverage report - scala 2.13.11

github-actions bot commented Aug 23, 2024

JaCoCo agent module code coverage report - scala 2.13.11

github-actions bot commented Aug 23, 2024 • edited Loading

JaCoCo server module code coverage report - scala 2.13.11

salamonpavel Aug 26, 2024

Choose a reason for hiding this comment

benedeki Aug 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 28, 2024

JaCoCo reader module code coverage report - scala 2.13.11

benedeki commented Aug 29, 2024

TebaleloS commented Aug 6, 2024 •

edited by miroslavpojer

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading