Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get checkpoint #241

Merged
merged 58 commits into from
Aug 21, 2024
Merged

get checkpoint #241

merged 58 commits into from
Aug 21, 2024

Conversation

salamonpavel
Copy link
Collaborator

@salamonpavel salamonpavel commented Aug 8, 2024 •
edited by miroslavpojer
Loading

Implements GET endpoint for checkpoint retrieval
Closes #231

Release notes:

  • Introduces GET endpoint for single checkpoint retrieval

@salamonpavel
postCheckpointEndpointV2
682354e
@salamonpavel
postCheckpointV2
b72ebfa
@salamonpavel
write_checkpoint_v2
7b7819c
@salamonpavel
fix existing tests
b4604c4
@salamonpavel
fixes related to error model
4b89a3a
@salamonpavel
fixes related to error model
47dea31
@salamonpavel
param name fix
cc4af62
@salamonpavel
exceptions imports
bb6331e
@salamonpavel
exceptions imports
19e6382
@salamonpavel
PostCheckpointEndpointV2UnitTests
a3ffb44
@salamonpavel
tests
928823d
@salamonpavel
tests
bf47223
@salamonpavel
remove unused import
c4245eb
@salamonpavel
get checkpoint
5133272
@salamonpavel
checkpointv2dto
b4ef957
@salamonpavel
checkpointv2dto
69169ba
@salamonpavel
checkpointv2dto
519790a
@salamonpavel
fix
6e3588b
@salamonpavel
fix
61d587b
@salamonpavel
fix
a46e3aa
@salamonpavel
fix
31652e5
@salamonpavel
Merge branch 'refs/heads/feature/232-post-checkpoint' into feature/23…
75b83b1 
…1-get-partitioning-checkpoint-232-based

# Conflicts:
#	model/src/main/scala/za/co/absa/atum/model/dto/CheckpointV2DTO.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepository.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryImpl.scala
#	server/src/main/scala/za/co/absa/atum/server/api/service/CheckpointService.scala
#	server/src/main/scala/za/co/absa/atum/server/model/CheckpointFromDB.scala
@salamonpavel
fix
c45b35d
@salamonpavel salamonpavel added work in progress Work on this item is not yet finished (mainly intended for PRs) Server Issues touching the server part of the project labels Aug 8, 2024
@salamonpavel salamonpavel self-assigned this Aug 8, 2024
salamonpavel and others added 22 commits August 13, 2024 16:40
@salamonpavel
refactoring as per discussion
2a62b39
@salamonpavel
Merge branch 'refs/heads/feature/232-post-checkpoint' into feature/23…
896c085 
…1-get-partitioning-checkpoint-232-based

# Conflicts:
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryImpl.scala
#	server/src/test/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryUnitTests.scala
@salamonpavel
refactoring as per discussion
bbe5efa
@salamonpavel
refactoring as per discussion
b8363a9
@salamonpavel
refactoring as per discussion
e99d863
@salamonpavel
fixes
f65b7c5
@salamonpavel
Merge branch 'refs/heads/feature/232-post-checkpoint' into feature/23…
c84847b 
…1-get-partitioning-checkpoint-232-based

# Conflicts:
#	server/src/main/scala/za/co/absa/atum/server/api/controller/BaseController.scala
#	server/src/main/scala/za/co/absa/atum/server/model/CheckpointFromDB.scala
#	server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerUnitTests.scala
@salamonpavel
docs for sql updated
4ad5505
@salamonpavel
Merge branch 'feature/232-post-checkpoint' into feature/231-get-parti…
03bdcbc 
…tioning-checkpoint-232-based
@salamonpavel
extend Exception instead of Throwable
f76e6f8
@salamonpavel @benedeki
Update database/src/main/postgres/runs/V1.9.2__write_checkpoint_v2.sql
73af31a 
Co-authored-by: David Benedeki <[email protected]>
@salamonpavel
github comments addressed
4a8eca2
@salamonpavel
v1 endpoint changed
2418cfd
@salamonpavel
v1 tests
ac41084
@salamonpavel
v1 tests
aec2ec1
@salamonpavel
v1 tests
6574bf1
@salamonpavel
rename
d8acd15
@salamonpavel
Merge branch 'refs/heads/feature/232-post-checkpoint' into feature/23…
6c3bbb3 
…1-get-partitioning-checkpoint-232-based

# Conflicts:
#	server/src/main/scala/za/co/absa/atum/server/Main.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryImpl.scala
#	server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerUnitTests.scala
#	server/src/test/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryUnitTests.scala
@salamonpavel
merge conflicts resolved
a6ada8d
@salamonpavel
overloaded sql code
867cf40
@salamonpavel
Merge branch 'refs/heads/feature/232-post-checkpoint' into feature/23…
ab7607e 
…1-get-partitioning-checkpoint-232-based

# Conflicts:
#	server/src/main/scala/za/co/absa/atum/server/Main.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryImpl.scala
#	server/src/test/scala/za/co/absa/atum/server/api/database/runs/functions/WriteCheckpointIntegrationTests.scala
#	server/src/test/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryUnitTests.scala
@salamonpavel
conflicts resolved
5c21538
Base automatically changed from feature/232-post-checkpoint to master August 21, 2024 06:19
@salamonpavel salamonpavel dismissed TebaleloS’s stale review August 21, 2024 06:19

The base branch was changed.

@salamonpavel
Merge branch 'refs/heads/master' into feature/231-get-partitioning-ch…
5336dcd 
…eckpoint-232-based

# Conflicts:
#	server/src/main/scala/za/co/absa/atum/server/Main.scala
#	server/src/main/scala/za/co/absa/atum/server/api/controller/BaseController.scala
#	server/src/main/scala/za/co/absa/atum/server/api/controller/CheckpointController.scala
#	server/src/main/scala/za/co/absa/atum/server/api/controller/CheckpointControllerImpl.scala
#	server/src/main/scala/za/co/absa/atum/server/api/exception/DatabaseError.scala
#	server/src/main/scala/za/co/absa/atum/server/api/exception/ServiceError.scala
#	server/src/main/scala/za/co/absa/atum/server/api/http/BaseEndpoints.scala
#	server/src/main/scala/za/co/absa/atum/server/api/http/Endpoints.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/BaseRepository.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepository.scala
#	server/src/main/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryImpl.scala
#	server/src/main/scala/za/co/absa/atum/server/api/service/BaseService.scala
#	server/src/main/scala/za/co/absa/atum/server/api/service/CheckpointService.scala
#	server/src/main/scala/za/co/absa/atum/server/api/service/CheckpointServiceImpl.scala
#	server/src/main/scala/za/co/absa/atum/server/model/CheckpointFromDB.scala
#	server/src/test/scala/za/co/absa/atum/server/api/controller/CheckpointControllerUnitTests.scala
#	server/src/test/scala/za/co/absa/atum/server/api/http/PostCheckpointEndpointV2UnitTests.scala
#	server/src/test/scala/za/co/absa/atum/server/api/repository/CheckpointRepositoryUnitTests.scala
#	server/src/test/scala/za/co/absa/atum/server/api/service/CheckpointServiceUnitTests.scala
@github-actions GitHub Actions
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 56.06% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 85.84% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 78.67% -22.33% 🍏
Files changed 54.87% ❌

File Coverage
CheckpointRepositoryImpl.scala 100% 🍏
ServiceError.scala 100% -479.17% ❌
DatabaseError.scala 100% -479.17% ❌
CheckpointServiceImpl.scala 100% 🍏
BaseService.scala 100% 🍏
BaseController.scala 100% 🍏
CheckpointControllerImpl.scala 100% 🍏
BaseRepository.scala 92.96% 🍏
CheckpointFromDB.scala 86.26% 🍏
CheckpointItemFromDB.scala 73.51% -276.82% ❌
GetPartitioningCheckpointV2.scala 49.87% -90.98% ❌

@salamonpavel salamonpavel merged commit 90494e9 into master Aug 21, 2024
9 of 10 checks passed
@salamonpavel salamonpavel deleted the feature/231-get-partitioning-checkpoint-232-based branch August 21, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak left review comments

@TebaleloS TebaleloS TebaleloS left review comments

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

Assignees

@salamonpavel salamonpavel

Labels
Server Issues touching the server part of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /partitionings/{partId}/checkpoints/{checkpId}
3 participants
@salamonpavel @lsulak @TebaleloS