#244: Create the Info module #248
Conversation
* created new module Info * the new modul added to JaCoco and CI routines
benedeki
requested review from
lsulak,
TebaleloS,
Zejnilovic,
dk1844 and
salamonpavel
as code owners
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
|
Release notes: |
|
|
||
| package za.co.absa.atum.info | ||
|
|
||
| class FLowInfo { |
There was a problem hiding this comment.
| class FLowInfo { | |
| class FlowInfo { |
build.sbt
Outdated
| * Module `info` is the library to be plugged into application which wants to easily read the measured data stored in the | ||
| * server | ||
| */ | ||
| lazy val info = (projectMatrix in file("info")) |
There was a problem hiding this comment.
the only thing is that I'm not sure about the name info; what about:
agent->agent-publisher,metrics-publisher,measurement-publisher,measure-publisher,publisher, or something like that, possibly instead ofpublisherwe can have:writerorproducer?info->agent-reader,metrics-reader,measurement-reader,measure-readerorreaderor something like that, possibly instead ofreaderwe can have:consumerorobserver?
There was a problem hiding this comment.
even a simple agent-publisher + agent-consumer or agent-writer + agent-reader can be a nice alternative
There was a problem hiding this comment.
Let's discuss the name on the team tech call.
There was a problem hiding this comment.
We agreed on Reader (Atum-Reader)
info/src/main/scala/za/co/absa/atum/info/PartitioningInfo.scala
Outdated
Show resolved
Hide resolved
…om/AbsaOSS/atum-service into feature/244-create-the-Info-module
JaCoCo reader module code coverage report - scala 2.13.11
|
* JaCoCo exclusion for model
| @@ -98,6 +109,8 @@ jobs: | |||
| run: | | |||
| echo "Total agent module coverage ${{ steps.jacoco-agent.outputs.coverage-overall }}" | |||
| echo "Changed Files coverage ${{ steps.jacoco-agent.outputs.coverage-changed-files }}" | |||
| echo "Total agent module coverage ${{ steps.jacoco-reader.outputs.coverage-overall }}" | |||
There was a problem hiding this comment.
wrong msg - this is about the reader coverage
| Setup.commonSettings ++ Seq( | ||
| name := "atum-reader", | ||
| javacOptions ++= Setup.clientJavacOptions, | ||
| publish / skip := true // module is not yet finished, so we don't want to publish it |
There was a problem hiding this comment.
there could be a ticket but I don't mind / insist
Closes #244
Release notes: