get partitioning additional data v2 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salamonpavel
added
Server
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
…ionalDataEndpointV2' into feature/227-getPartitioningAdditionalDataEndpointV2
|
Release notes:
|
salamonpavel
requested review from
benedeki,
lsulak,
TebaleloS,
Zejnilovic and
dk1844
as code owners
salamonpavel
removed
the
work in progress
benedeki
reviewed
Aug 26, 2024
database/src/main/postgres/runs/V1.9.6__get_partitioning_additional_data.sql
Outdated
Show resolved
Hide resolved
| mapToSingleSuccessResponse( | ||
| serviceCall[AdditionalDataDTO, AdditionalDataDTO]( | ||
| partitioningService.getPartitioningAdditionalDataV2(partitioningId), | ||
| identity |
There was a problem hiding this comment.
Just an idea, what about having identity as the default parameter value? 🤔
There was a problem hiding this comment.
Yup, good idea. Applied.
server/src/main/scala/za/co/absa/atum/server/model/AdditionalDataItemFromDB.scala
Show resolved
Hide resolved
…ional_data.sql Co-authored-by: David Benedeki <[email protected]>
lsulak
reviewed
Aug 26, 2024
| @@ -64,18 +64,36 @@ trait TestData { | |||
| protected val measureFromDB1: MeasureFromDB = MeasureFromDB(Some("count1"), Some(Seq("col_A1", "col_B1"))) | |||
| protected val measureFromDB2: MeasureFromDB = MeasureFromDB(Some("count2"), Some(Seq("col_A2", "col_B2"))) | |||
|
|
|||
| // Additional Data | |||
| protected val additionalDataDTO1: InitialAdditionalDataDTO = Map( | |||
| // Initial Additional Data | |||
There was a problem hiding this comment.
I think initial is not descriptive enough (obviously not just here but also in the model's DTO) 🤔
There was a problem hiding this comment.
It's only a temporary name so that I can distinguish between newly created types and existing ones. The code related to InitialAdditionalData will be refactored to use the newly created classes. But it's going to be done in a separate PR in order to not affect scope of individual tickets.
|
LGTM, just one comment regarding the |
lsulak
approved these changes
Aug 26, 2024
benedeki
approved these changes
Aug 26, 2024
salamonpavel
deleted the
feature/227-getPartitioningAdditionalDataEndpointV2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces GET endpoint for retrieving partitioning's additional data
Closes #227
Release notes: