patch additional data #253
Conversation
salamonpavel
added
Server
salamonpavel
changed the title
|
Release notes:
|
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningService.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningServiceImpl.scala
JaCoCo reader module code coverage report - scala 2.13.11
|
# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningServiceImpl.scala # server/src/test/scala/za/co/absa/atum/server/api/service/PartitioningServiceUnitTests.scala
salamonpavel
requested review from
benedeki,
lsulak,
TebaleloS,
Zejnilovic and
dk1844
as code owners
salamonpavel
removed
the
work in progress
| fr"${values.additionalData.map { case (k, v) => (k, v.orNull) }}", | ||
| fr"${values.author}" | ||
| fr"${args.partitioningId}", | ||
| fr"${args.additionalData.data}", |
There was a problem hiding this comment.
I'll take a deeper and proper look later, but why it's not allowed to have Option there?
There was a problem hiding this comment.
We don't want to allow 'empty' values for PATCH operation. That's been discussed. Do you think we should reconsider the decision?
There was a problem hiding this comment.
@lsulak Option is to enable None/Null for cases to signal that some additional data are expected, but hasn't been defined yet.
Undefining data, that has been already set makes no sense.
There was a problem hiding this comment.
Okay, thanks for the explanation
# Conflicts: # server/src/test/scala/za/co/absa/atum/server/api/database/runs/functions/WriteCheckpointV2IntegrationTests.scala
| $$ | ||
| ------------------------------------------------------------------------------- | ||
| ------------------------------------------------------------------------------- |
There was a problem hiding this comment.
I do not recall adding this whitespace, probably automatic formatting was applied ... Commit below accepted.
database/src/main/postgres/runs/V1.5.16__create_or_update_additional_data.sql
Show resolved
Hide resolved
| fr"${values.additionalData.map { case (k, v) => (k, v.orNull) }}", | ||
| fr"${values.author}" | ||
| fr"${args.partitioningId}", | ||
| fr"${args.additionalData.data}", |
There was a problem hiding this comment.
@lsulak Option is to enable None/Null for cases to signal that some additional data are expected, but hasn't been defined yet.
Undefining data, that has been already set makes no sense.
…tional_data.sql Co-authored-by: David Benedeki <[email protected]>
database/src/main/postgres/runs/V1.5.16__create_or_update_additional_data.sql
Outdated
Show resolved
Hide resolved
…tional_data.sql Co-authored-by: David Benedeki <[email protected]>
Introduces PATCH endpoint for additional data
Closes #221
Release notes: