Feature/224 post partitioning #258

salamonpavel · 2024-09-03T14:40:35Z

Introduces POST endpoint for partitioning creation
Closes #224

Release notes:

Introduces POST endpoint for partitioning creation

# Conflicts: # server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/http/Routes.scala # server/src/main/scala/za/co/absa/atum/server/api/repository/PartitioningRepositoryImpl.scala # server/src/main/scala/za/co/absa/atum/server/api/service/PartitioningServiceImpl.scala

salamonpavel · 2024-09-03T14:40:56Z

Release notes

Introduces POST endpoint for partitioning creation

github-actions · 2024-09-03T14:43:21Z

JaCoCo model module code coverage report - scala 2.13.11

Overall Project	63.64%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-09-03T14:43:22Z

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project	84.63%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-09-03T14:43:23Z

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project	100%	🍏

There is no coverage information present for the Files changed

github-actions · 2024-09-03T14:43:24Z

JaCoCo server module code coverage report - scala 2.13.11

Overall Project	76.37% `-3.82%`	🍏
Files changed	83.27%	🍏

File	Coverage
PartitioningRepositoryImpl.scala	100%	🍏
PartitioningServiceImpl.scala	100%	🍏
PartitioningControllerImpl.scala	88.78%	🍏
CreatePartitioning.scala	69.83% `-37.29%`	🍏
CreatePartitioningIfNotExists.scala	69.04% `-38.43%`	🍏

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

lsulak · 2024-09-11T11:12:01Z

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

+    _status                 BIGINT;
+BEGIN
+
+id_partitioning := runs._get_id_partitioning(i_partitioning, true);


the alignment of the fnc body needs to be shifted by 1 tab or something to the right

lsulak · 2024-09-11T11:15:16Z

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

+    status := 11;
+    status_text := 'Partitioning created';
+ELSE
+    status := 31;


what, is this the only difference, the status code for situation when partitioning is already present? In comparison to runs.create_partitioning_if_not_exists function. Otherwise I think this is 1:1 copy almost

so I think we shouldn't have same implementation twice..possibly just call runs.create_partitioning_if_not_exists from this function and change the status code in select / case when statement, if this is really needed

There is a difference in that the new function does register parent partitioning only when the child partitioning does not exist. Anyway I think we should have a call maybe about the create partitioning operation in general ...

Let's find a spot tomorrow. I think/hope it won't be long.

Co-authored-by: Ladislav Sulak <[email protected]>

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

salamonpavel · 2024-09-17T07:50:05Z

The code has been updated. Most of previous comments about the SQL part have become obsolete as the function has been refactored and simplified. @benedeki and @lsulak

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala

benedeki

code reviewed
pulled
built
run

lsulak · 2024-09-17T11:16:22Z

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

+
+    INSERT INTO runs.partitionings (partitioning, created_by)
+    VALUES (i_partitioning, i_by_user)
+    RETURNING partitionings.id_partitioning INTO create_partitioning.id_partitioning;


I didn't know that these were possible :)

lsulak · 2024-09-17T11:17:12Z

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

+-- Parameters:
+--      i_partitioning              - partitioning to create or which existence to check
+--      i_by_user                   - user behind the change
+--      i_parent_partitioning_id    - (optional) parent partitioning id


Suggested change

-- i_parent_partitioning_id - (optional) parent partitioning id

-- i_parent_partitioning_id - (optional) parent partitioning id, must already exist if specified

or something like that

salamonpavel added 3 commits September 3, 2024 12:03

tmp commit

1e097fb

tests

6537241

CreatePartitioningIntegrationTests

b380095

salamonpavel marked this pull request as ready for review September 3, 2024 14:57

salamonpavel requested review from benedeki, lsulak, TebaleloS, Zejnilovic and dk1844 as code owners September 3, 2024 14:57

Merge branch 'master' into feature/224-post-partitioning

4ad5189

salamonpavel self-assigned this Sep 6, 2024

salamonpavel added 2 commits September 10, 2024 11:15

Merge branch 'master' into feature/224-post-partitioning

4bc6804

Update V1.9.7__create_partitioning.sql

919f34c

lsulak reviewed Sep 11, 2024

View reviewed changes

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql Outdated Show resolved Hide resolved

lsulak reviewed Sep 11, 2024

View reviewed changes

salamonpavel and others added 2 commits September 12, 2024 09:31

Update database/src/main/postgres/runs/V1.9.7__create_partitioning.sql

43bc8f1

Co-authored-by: Ladislav Sulak <[email protected]>

comments addressed

faa6548

benedeki reviewed Sep 13, 2024

View reviewed changes

salamonpavel added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Sep 17, 2024

salamonpavel added 2 commits September 17, 2024 09:23

sql refactored

0043c61

tests fixed

22e4ac0

salamonpavel removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Sep 17, 2024

benedeki reviewed Sep 17, 2024

View reviewed changes

database/src/main/postgres/runs/V1.9.7__create_partitioning.sql Show resolved Hide resolved

server/src/main/scala/za/co/absa/atum/server/api/controller/PartitioningControllerImpl.scala Show resolved Hide resolved

benedeki approved these changes Sep 17, 2024

View reviewed changes

salamonpavel merged commit 3398044 into master Sep 17, 2024
10 of 11 checks passed

salamonpavel deleted the feature/224-post-partitioning branch September 17, 2024 11:15

lsulak reviewed Sep 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/224 post partitioning #258

Feature/224 post partitioning #258

salamonpavel commented Sep 3, 2024 •

edited by miroslavpojer

Loading

salamonpavel commented Sep 3, 2024

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

lsulak Sep 11, 2024

salamonpavel Sep 12, 2024

lsulak Sep 11, 2024

lsulak Sep 11, 2024

salamonpavel Sep 12, 2024

benedeki Sep 13, 2024

salamonpavel commented Sep 17, 2024

benedeki left a comment

lsulak Sep 17, 2024

lsulak Sep 17, 2024

	-- i_parent_partitioning_id - (optional) parent partitioning id
	-- i_parent_partitioning_id - (optional) parent partitioning id, must already exist if specified

Feature/224 post partitioning #258

Feature/224 post partitioning #258

Conversation

salamonpavel commented Sep 3, 2024 • edited by miroslavpojer Loading

salamonpavel commented Sep 3, 2024

github-actions bot commented Sep 3, 2024 • edited Loading

JaCoCo model module code coverage report - scala 2.13.11

github-actions bot commented Sep 3, 2024 • edited Loading

JaCoCo agent module code coverage report - scala 2.13.11

github-actions bot commented Sep 3, 2024 • edited Loading

JaCoCo reader module code coverage report - scala 2.13.11

github-actions bot commented Sep 3, 2024 • edited Loading

JaCoCo server module code coverage report - scala 2.13.11

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salamonpavel commented Sep 17, 2024

benedeki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salamonpavel commented Sep 3, 2024 •

edited by miroslavpojer

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading