PartitioningUpdateException #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salamonpavel
requested review from
benedeki,
lsulak,
TebaleloS,
Zejnilovic and
dk1844
as code owners
|
Release notes:
|
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
benedeki
reviewed
Sep 9, 2024
| @@ -52,7 +53,14 @@ class AtumContext private[agent] ( | |||
| * @return the sub-partition context | |||
| */ | |||
| def subPartitionContext(subPartitions: AtumPartitions): AtumContext = { | |||
| agent.getOrCreateAtumSubContext(atumPartitions ++ subPartitions)(this) | |||
| val newPartitions = subPartitions.foldLeft(atumPartitions) { case (acc, (k, v)) => | |||
There was a problem hiding this comment.
Just an idea. Wouldn't intersection be clearer, what's being checked?
val overlap = atumPartitions.keys.intersect(subPartitions.keys)
if (overlap.nonEmpty) {
throw PartitioningUpdateException(s"Partition keys '$overlap' already exist. Updates are not allowed.")
}There was a problem hiding this comment.
okok, refactored
benedeki
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sub partitions context creation.
Fixes #261
Release notes: