#305 Get-Ancestors-Server Functionality #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Made the necessary changes as mentioned by the team. 3. Made the necessary changes to the getAncestors Database functionality.
1. Made the necessary changes as mentioned by the team. 3. Made the necessary changes to the getAncestors Server functionality.
ABLL526
requested review from
benedeki,
lsulak,
Zejnilovic,
dk1844 and
salamonpavel
as code owners
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
ABLL526
added
enhancement
ABLL526
changed the title
ABLL526
changed the title
| @@ -0,0 +1,121 @@ | |||
| /* | |||
There was a problem hiding this comment.
I guess this shouldn't even be part of this PR as there is #311
|
|
||
| object GetAncestorsResult { | ||
|
|
||
| @tailrec def resultsToPartitioningWithIdDTOs( |
There was a problem hiding this comment.
The very same code already exists in GetFlowPartitioning, maybe we could introduce some abstraction and reuse it here.
| @@ -40,6 +40,8 @@ object ApiPaths { | |||
| final val Flows = "flows" | |||
| final val Measures = "measures" | |||
| final val MainFlow = "main-flow" | |||
| final val Ancestors = "ancestors" | |||
| final val Parents = "parents" | |||
| PartitioningController.getAncestors(partitioningId, limit, offset) | ||
| } | ||
| ), | ||
| // createServerEndpoint[ |
There was a problem hiding this comment.
Not part of this PR (the commented-out code). This goes for multiple places. You can remove all the code unrelated to this PR I think...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the getAncestors Functionality for the Server Portion