Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#273 Patch-Parents-Database #313

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ABLL526
Copy link

@ABLL526 ABLL526 commented Jan 21, 2025

Added the Patch Parents Database functionality.
Any feedback is welcome.

1. Made the necessary changes as mentioned by the team.
3. Made the necessary changes to the getAncestors Database functionality.
1. Made the necessary changes as mentioned by the team.
3. Made the necessary changes to the getAncestors Server functionality.
1. Made the necessary changes as mentioned by the team.
3. Made the necessary changes to the PatchParents Database functionality.
@ABLL526 ABLL526 self-assigned this Jan 21, 2025
@ABLL526 ABLL526 added enhancement New feature or request good first issue Good for newcomers DB Issues touching the Database part of the project Server Issues touching the server part of the project labels Jan 21, 2025
@ABLL526 ABLL526 linked an issue Jan 21, 2025 that may be closed by this pull request
@ABLL526 ABLL526 changed the title 272-Patch-Parents-Database #273 Patch-Parents-Database Jan 21, 2025
Copy link

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 58.76% 🍏

There is no coverage information present for the Files changed

Copy link

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 78.2% 🍏

There is no coverage information present for the Files changed

Copy link

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project 90.86% 🍏

There is no coverage information present for the Files changed

Copy link

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 68.76% -6.62% 🍏
Files changed 62.68%

File Coverage
PartitioningRepositoryImpl.scala 100% 🍏
PartitioningServiceImpl.scala 100% 🍏
PartitioningControllerImpl.scala 92.72% 🍏
GetAncestors.scala 70.96%

@@ -0,0 +1,121 @@
/*
Copy link
Collaborator

@salamonpavel salamonpavel Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't belong to this PR. Applies to many other files as well ....

-------------------------------------------------------------------------------
--
-- Function: runs.add_parent(5)
-- Add the Parent Partition for a given partition ID and copies measurements and additional data from parent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partition != Partitioning (as mentioned in previous PRs)

RETURN;
END IF;

-- SELECT F.id_flow as mainFlow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

--
-------------------------------------------------------------------------------
DECLARE
Additional_Data HSTORE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional_data

Copy link
Collaborator

@salamonpavel salamonpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up this PR. It cannot contain unrelated code. You should introduce only code related to the patch operation on the database level if that's what this PR is intended for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB Issues touching the Database part of the project enhancement New feature or request good first issue Good for newcomers Server Issues touching the server part of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATCH /partitionings/{partId}/parents
2 participants