scalafmt config more close to scala style guide #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsulak
reviewed
Oct 20, 2023
| @@ -3,7 +3,7 @@ runner.dialect = scala212 | |||
|
|
|||
| maxColumn = 120 | |||
|
|
|||
| align.preset = some | |||
| align.preset = none | |||
There was a problem hiding this comment.
I quite liked some here, but I'd like to hear your opinion on this one (i.e. why none ? )
There was a problem hiding this comment.
It definitely may look nice in some instances, but it creates unnecessary changes in diff. It also may create lines longer than the limit, where it would not happen without it.
Those are not huge issues, so I am ok using 'some' if you think it's worth it.
There was a problem hiding this comment.
let's go with none then and we'll see if we need to change it back 👍
lsulak
reviewed
Oct 20, 2023
| align.openParenCallSite = true | ||
|
|
||
| align.openParenDefnSite = false | ||
| align.openParenCallSite = false |
There was a problem hiding this comment.
Nice, it works, I just tested it & I like it
JaCoCo agent module code coverage report - spark:2 - scala 2.12.12
|
JaCoCo server module code coverage report - scala 2.12.12
|
cerveada
requested review from
benedeki,
TebaleloS,
Zejnilovic,
dk1844 and
salamonpavel
as code owners
lsulak
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.