(only idea!) #94 measure validation on column #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-creation-function # Conflicts: # agent/src/main/scala/za/co/absa/atum/agent/AtumContext.scala # agent/src/test/scala/za/co/absa/atum/agent/AtumContextTest.scala
lsulak
requested review from
benedeki,
TebaleloS,
Zejnilovic,
dk1844 and
salamonpavel
as code owners
lsulak
commented
Oct 25, 2023
… unit tests, refactoring & simplification
…nt-creation-function # Conflicts: # agent/src/main/scala/za/co/absa/atum/agent/AtumContext.scala # agent/src/main/scala/za/co/absa/atum/agent/model/Checkpoint.scala
…unction' into feature/94-measure-validation-on-column # Conflicts: # agent/src/main/scala/za/co/absa/atum/agent/AtumContext.scala # agent/src/main/scala/za/co/absa/atum/agent/model/Measure.scala # project/Dependencies.scala
benedeki
reviewed
Oct 27, 2023
|
|
||
| def currentMeasures: Set[Measure] = measures | ||
|
|
||
| def subPartitionContext(subPartitions: AtumPartitions): AtumContext = { | ||
| agent.getOrCreateAtumSubContext(atumPartitions ++ subPartitions)(this) | ||
| } | ||
|
|
||
| private def validateMeasureApplicability(measure: Measure, df: DataFrame): Unit = { |
There was a problem hiding this comment.
Would make this a method of Measure, so it can actually be customized based on each function.
There was a problem hiding this comment.
Good idea actually. Measure can have this one implemented in it, and individual ones can override if needed. Especially useful for Measures that don't operate on any column, such as count
…4-measure-validation-on-column
…unction' into feature/94-measure-validation-on-column # Conflicts: # agent/src/test/scala/za/co/absa/atum/agent/AtumContextTest.scala
…nt-creation-function # Conflicts: # agent/src/main/scala/za/co/absa/atum/agent/AtumContext.scala
…unction' into feature/94-measure-validation-on-column # Conflicts: # agent/src/main/scala/za/co/absa/atum/agent/AtumContext.scala # agent/src/test/scala/za/co/absa/atum/agent/AtumContextTest.scala
…do this differently
…4-measure-validation-on-column
Base automatically changed from
feature/26-checkpoint-creation-function
to
master
November 1, 2023 10:22
lsulak
added
the
work in progress
lsulak
changed the title
|
Probably not gonna do it like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation of measure calculations on agent side.
Closes #94
Note: don't review this one please, it might even be disregarded. It was just an idea!