-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models and interfaces #33
Conversation
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
6fae81f
to
fc86dce
Compare
fc86dce
to
b4469b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few times there are
-
todos in the code,
I am not quite sure whether it is todo for future, or something that was intended to be fixešd before the PR... so amybe check them which ones you forgot to finish, and which ones are to survive -
commented code - this should not be in the repo, that is what git is for, wither remove obsolete parts, or put alternatives to config, or something what is not commented out code
-
data + sample outputs (quite substantial) in code
-> I would consider relocating those to separate repo, so codebase is not tangled with data
closes #28 and sub tickets: closes #23 closes #25 closes #26 closes #16
This pull request did big refactoring. PR introduced a new folder structure and it repaired some badly working code