Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models and interfaces #33

Merged
merged 55 commits into from
Nov 26, 2024
Merged

Conversation

OlivieFranklova
Copy link
Collaborator

@OlivieFranklova OlivieFranklova commented Sep 18, 2024

closes #28 and sub tickets: closes #23 closes #25 closes #26 closes #16

This pull request did big refactoring. PR introduced a new folder structure and it repaired some badly working code

@OlivieFranklova OlivieFranklova self-assigned this Sep 18, 2024
@OlivieFranklova OlivieFranklova linked an issue Sep 18, 2024 that may be closed by this pull request
@OlivieFranklova OlivieFranklova removed a link to an issue Sep 18, 2024
@OlivieFranklova OlivieFranklova linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2315 1956 84% 70% 🟢

New Files

File Coverage Status
logging_.py 100% 🟢
similarity_framework/src/impl/comparator/distance_functions.py 88% 🟢
similarity_framework/src/impl/comparator/utils.py 84% 🟢
similarity_framework/src/interfaces/common.py 100% 🟢
similarity_framework/src/interfaces/comparator/comparator.py 87% 🟢
similarity_framework/src/interfaces/metadata/metadata_creator.py 95% 🟢
similarity_framework/src/models/settings.py 97% 🟢
similarity_framework/src/models/similarity.py 100% 🟢
similarity_framework/src/models/types_.py 70% 🟢
tests/similarity_framework/test_similarity_comparator.py 100% 🟢
TOTAL 92% 🟢

Modified Files

File Coverage Status
constants.py 80% 🟢
TOTAL 80% 🟢

updated for commit: e09c45d by action🐍

@OlivieFranklova OlivieFranklova added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Sep 20, 2024
@OlivieFranklova OlivieFranklova marked this pull request as draft September 23, 2024 08:13
This was linked to issues Oct 2, 2024
@OlivieFranklova OlivieFranklova force-pushed the feature/models-and-interfaces branch 2 times, most recently from 6fae81f to fc86dce Compare October 2, 2024 13:33
@OlivieFranklova OlivieFranklova force-pushed the feature/models-and-interfaces branch from fc86dce to b4469b7 Compare October 3, 2024 07:42
Copy link

@ABMC831 ABMC831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few times there are

  1. todos in the code,
    I am not quite sure whether it is todo for future, or something that was intended to be fixešd before the PR... so amybe check them which ones you forgot to finish, and which ones are to survive

  2. commented code - this should not be in the repo, that is what git is for, wither remove obsolete parts, or put alternatives to config, or something what is not commented out code

  3. data + sample outputs (quite substantial) in code
    -> I would consider relocating those to separate repo, so codebase is not tangled with data

@OlivieFranklova OlivieFranklova merged commit 6fe5e2e into master Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants