Feature/120 change latest tag selection from time to semantic #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented new inpout to define from tag. - Newly user is able to control start point for Release Notes generation.
- Several pylint fixes.
- Applied to project's release draft yaml file.
- Replaced time ordering by semantic one when no from tag defined.
MobiTikula
reviewed
Dec 9, 2024
There was a problem hiding this comment.
I like the way of use semver library. There are some comments, but they are already mentioned in PR #121.
…om-time-to-semantic # Conflicts: # release_notes_generator/generator.py # release_notes_generator/utils/pull_reuqest_utils.py # tests/test_action_inputs.py # tests/test_release_notes_generator.py
MobiTikula
reviewed
Dec 9, 2024
release_notes_generator/generator.py
Outdated
| @@ -81,7 +82,7 @@ def generate(self) -> Optional[str]: | |||
| return None | |||
|
|
|||
| # get the latest release | |||
| rls: GitRelease = self.get_latest_release(repo) | |||
| rls = self.get_latest_release(repo) | |||
release_notes_generator/generator.py
Outdated
| if ActionInputs.is_from_tag_name_defined(): | ||
| logger.info("Getting latest release by from-tag name %s", ActionInputs.get_tag_name()) | ||
| rls: GitRelease = self._safe_call(repo.get_release)(ActionInputs.get_from_tag_name()) | ||
| rls = self._safe_call(repo.get_release)(ActionInputs.get_from_tag_name()) |
miroslavpojer
deleted the
feature/120-Change-latest-tag-selection-from-time-to-semantic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Closes #120