-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#17 - Action migration to composite #18
#17 - Action migration to composite #18
Conversation
- Updated action.yml file. - Renamed and updated main python file.
Release notes:
|
- Remove of node.js related lines from README.md.
…composite # Conflicts: # README.md # src/controller.py # src/living_documentation_generator.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comments I suggest to update .gitignore file.
import sys | ||
|
||
|
||
def extend_args(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we have these extend_args?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current solution, we have multiple scripts that share config across system env variables. Here, we define paths in one place in the controller.
What change do you expect? I do not see any change request. |
I suggest to remove Also I still see index.js in the project, is it intentionally? Composite actions should not use javascript at all via: https://docs.github.com/en/actions/creating-actions/creating-a-composite-action and also example Composite actions. |
Great findings. All of them should be fixed. |
Closes #17