-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/57 prepare action inputs for several regimes #72
Feature/57 prepare action inputs for several regimes #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pulled
- code review
- unit tests ran
- local run performed.
During local run I have observed these issues (decide if fix here or in solo issue):
2024-11-29 13:50:24 - DEBUG - KeyError('number') occurred while parsing issue json: {'content': {}, 'fieldValues': {'nodes': [{'__typename': 'ProjectV2ItemFieldUserValue'}, {'__typename': 'ProjectV2ItemFieldRepositoryValue'}, {'__typename': 'ProjectV2ItemFieldLabelValue'}, {'__typename': 'ProjectV2ItemFieldReviewerValue'}, {'__typename': 'ProjectV2ItemFieldTextValue'}, {'__typename': 'ProjectV2ItemFieldSingleSelectValue', 'name': 'Done'}]}}.
2024-11-29 13:50:24 - DEBUG - Method get_project_issues returned [<living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074d3310>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f33d0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f1f50>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f0910>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f2650>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f02d0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f2550>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f36d0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f2490>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074f0610>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f150>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f050>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f390>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f510>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f790>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f7d0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f810>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f690>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f650>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11183f4d0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074efd10>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1074efdd0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11185fb90>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11185fc50>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11185fd50>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11185fe10>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11185fed0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x11185ff90>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111868090>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111868150>, <living_documentation_regime.model.project_issue.ProjectIssue object
2024-11-29 13:50:25 - DEBUG - Method get_project_issues returned [<living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854290>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854b10>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854810>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854310>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854210>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854190>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854110>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111847610>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x1118479d0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111854490>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111847910>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111847ad0>, <living_documentation_regime.model.project_issue.ProjectIssue object at 0x111847c50>, <living_documentation_regime.model.project_issue.ProjectIssue object a
Issues are wrong log messages. Their output is not readable for end user.
The DEBUG logging comment was solved in commit: ae71977. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pulled
- local run
- code review
This reverts commit 165ad6f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pulled
- local ran
- code review
Remove unexp[ected change of input type format.
Confirm action is usable from CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pulled
- core revide
- local ran
- CI ran
@@ -218,7 +217,7 @@ export INPUT_GITHUB_TOKEN=$(printenv GITHUB_TOKEN) | |||
export INPUT_LIV_DOC_REGIME=true | |||
export INPUT_VERBOSE_LOGGING=true | |||
|
|||
# Environment variables for Living Documentation regime functionality | |||
# Environment variables for LivDoc regime functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Environment variables for LivDoc regime functionality | |
# Environment variables for Living Documentation (LivDoc) regime functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of next issue: #75 (comment).
|
||
Our project is designed with a myriad of features to ensure seamless user experience, top-tier functionality, and efficient operations. | ||
Here, you'll find a summarized list of all these features, their brief descriptions, and links to their detailed documentation. | ||
# Issue Summary page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the meta data were removed?
Are you presenting the Preview of expected output or raw data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you requested to rollback the changes, I implemented, cause they are not the part of solution for this PR. I do update them back in the next issue: #75 (comment).
This PR creates a breaking change of restructuring the project to be able to add multiple mining regimes to the generator in the future (generator is supposed to support CI mining, Incident mining etc.). This PR was done in several steps:
Release Notes:
Closes #57