-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3 from AbsaOSS/feature/2-Implement-basic-logic-fo…
…r-Release-notes-located-in-PR-body #2 - Implement basic logic for Release notes located in PR body
- Loading branch information
Showing
22 changed files
with
2,151 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* @miroslavpojer @Zejnilovic @benedeki |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
labels: 'bug' | ||
|
||
--- | ||
|
||
## Describe the bug | ||
A clear and concise description of what the bug is. | ||
|
||
## To Reproduce | ||
Steps to reproduce the behavior OR commands run: | ||
1. Go to '...' | ||
2. Click on '....' | ||
3. Enter value '...' | ||
4. See error | ||
|
||
## Expected behavior | ||
A clear and concise description of what you expected to happen. | ||
|
||
## Screenshots | ||
If applicable, add screenshots to help explain your problem. | ||
|
||
## Additional context | ||
Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
labels: 'enhancement' | ||
|
||
--- | ||
|
||
## Background | ||
A clear and concise description of where the limitation lies. | ||
|
||
## Feature | ||
A description of the requested feature. | ||
|
||
## Example [Optional] | ||
A simple example if applicable. | ||
|
||
## Proposed Solution [Optional] | ||
Solution Ideas: | ||
1. | ||
2. | ||
3. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
name: Question | ||
about: Ask a question | ||
labels: 'question' | ||
|
||
--- | ||
|
||
## Background [Optional] | ||
A clear explanation of the reason for raising the question. | ||
This gives us a better understanding of your use cases and how we might accommodate them. | ||
|
||
## Question | ||
A clear and concise inquiry |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
--- | ||
name: Spike | ||
about: Issue template for spikes, research and investigation tasks | ||
labels: 'spike' | ||
|
||
--- | ||
|
||
## Background | ||
A clear and concise description of the problem or a topic we need to understand. | ||
|
||
Feel free to add information about why it's needed and what assumptions you have at the moment. | ||
|
||
## Questions To Answer | ||
|
||
1. | ||
2. | ||
3. | ||
|
||
## Desired Outcome | ||
|
||
The list of desired outcomes of this spike ticket. | ||
|
||
```[tasklist] | ||
### Tasks | ||
- [ ] Questions have been answered or we have a clearer idea of how to get to our goal | ||
- [ ] Discussion with the team | ||
- [ ] Documentation | ||
- [ ] Create recommendations and new implementation tickets | ||
- [ ] item here.. | ||
``` | ||
|
||
## Additional Info/Resources [Optional] | ||
|
||
1. | ||
2. | ||
3. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
# | ||
# Copyright 2024 ABSA Group Limited | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
name: Check PR Release Notes in Description | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened, edited, labeled, unlabeled] | ||
branches: [ master ] | ||
|
||
env: | ||
SKIP_LABEL: 'no RN' | ||
RLS_NOTES_TAG_REGEX: 'Release Notes:' | ||
|
||
jobs: | ||
check-release-notes: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Get Pull Request Info | ||
id: pr_info | ||
uses: actions/github-script@v7 | ||
with: | ||
script: | | ||
const pr_number = context.payload.pull_request.number; | ||
const pr = await github.rest.pulls.get({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
pull_number: pr_number | ||
}); | ||
const labels = pr.data.labels ? pr.data.labels.map(label => label.name) : []; | ||
if (labels.includes("${{ env.SKIP_LABEL }}")) { | ||
console.log("Skipping release notes check because '${{ env.SKIP_LABEL }}' label is present."); | ||
core.setOutput("skip_check", 'true'); | ||
core.setOutput("pr_body", ""); | ||
return; | ||
} | ||
const pr_body = pr.data.body; | ||
if (!pr_body) { | ||
core.setFailed("Pull request description is empty."); | ||
core.setOutput("pr_body", ""); | ||
core.setOutput("skip_check", 'false'); | ||
return; | ||
} | ||
core.setOutput("pr_body", pr_body); | ||
core.setOutput("skip_check", 'false'); | ||
return; | ||
- name: Skip check if SKIP_LABEL is present | ||
if: steps.pr_info.outputs.skip_check == 'true' | ||
run: echo "Skipping release notes validation." | ||
|
||
- name: Check for 'Release Notes:' and bullet list | ||
if: steps.pr_info.outputs.skip_check == 'false' | ||
run: | | ||
# Extract the body from the previous step | ||
PR_BODY="${{ steps.pr_info.outputs.pr_body }}" | ||
# Check if "Release Notes:" exists | ||
if ! echo "$PR_BODY" | grep -q '${{ env.RLS_NOTES_TAG_REGEX }}'; then | ||
echo "Error: release notes tag not found in pull request description. Has to adhere to format '${{ env.RLS_NOTES_TAG_REGEX }}'." | ||
exit 1 | ||
fi | ||
# Extract text after "Release Notes:" line | ||
TEXT_BELOW_RELEASE_NOTES_TAG=$(echo "$PR_BODY" | sed -n '/${{ env.RLS_NOTES_TAG_REGEX }}/,$p' | tail -n +2) | ||
# Check if there's a bullet list (lines starting with '-', '+' or '*') | ||
if ! echo "$TEXT_BELOW_RELEASE_NOTES_TAG" | grep -qE '^\s*[-+*]\s+.+$'; then | ||
echo "Error: No bullet list found under release notes tag." | ||
exit 1 | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
# | ||
# Copyright 2024 ABSA Group Limited | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
name: Release - create draft release | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
tag-name: | ||
description: 'Name of git version tag to be created, and then draft release created. Syntax: "v[0-9]+.[0-9]+.[0-9]+".' | ||
required: true | ||
|
||
jobs: | ||
check-tag: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
|
||
- uses: actions/[email protected] | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Version Tag Check | ||
id: version_tag_check | ||
uses: AbsaOSS/version-tag-check@master | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
github-repository: ${{ github.repository }} | ||
version-tag: ${{ github.event.inputs.tag-name }} | ||
branch: 'master' | ||
fails-on-error: 'true' | ||
|
||
release-draft: | ||
needs: check-tag | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
persist-credentials: false | ||
|
||
- uses: actions/[email protected] | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Generate Release Notes | ||
id: generate_release_notes | ||
uses: AbsaOSS/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
tag-name: ${{ github.event.inputs.tag-name }} | ||
chapters: '[ | ||
{"title": "No entry 🚫", "label": "duplicate"}, | ||
{"title": "No entry 🚫", "label": "invalid"}, | ||
{"title": "No entry 🚫", "label": "wontfix"}, | ||
{"title": "No entry 🚫", "label": "no RN"}, | ||
{"title": "Breaking Changes 💥", "label": "breaking-change"}, | ||
{"title": "New Features 🎉", "label": "enhancement"}, | ||
{"title": "New Features 🎉", "label": "feature"}, | ||
{"title": "Bugfixes 🛠", "label": "bug"}, | ||
{"title": "Infrastructure ⚙️", "label": "infrastructure"}, | ||
{"title": "Silent-live 🤫", "label": "silent-live"}, | ||
{"title": "Documentation 📜", "label": "documentation"} | ||
]' | ||
skip-release-notes-label: 'no RN' | ||
verbose: true | ||
|
||
warnings: true | ||
print-empty-chapters: true | ||
|
||
|
||
- name: Create and Push Tag | ||
uses: actions/github-script@v7 | ||
with: | ||
script: | | ||
const tag = core.getInput('tag-name') | ||
const ref = `refs/tags/${tag}`; | ||
const sha = context.sha; // The SHA of the commit to tag | ||
await github.rest.git.createRef({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
ref: ref, | ||
sha: sha | ||
}); | ||
console.log(`Tag created: ${tag}`); | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
tag-name: ${{ github.event.inputs.tag-name }} | ||
|
||
- name: Create Draft Release | ||
uses: softprops/action-gh-release@v1 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
name: ${{ github.event.inputs.tag-name }} | ||
body: ${{ steps.generate_release_notes.outputs.release-notes }} | ||
tag_name: ${{ github.event.inputs.tag-name }} | ||
draft: true | ||
prerelease: false |
Oops, something went wrong.