After Release fix #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added hint how to get values.
- Removed valid output.
MobiTikula
reviewed
Nov 25, 2024
README.md
Outdated
| @@ -85,12 +74,11 @@ See the default action step definition: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| with: | |||
| github-repository: "{ org }/{ repo }" | |||
| pr-numer: 109 | |||
| github-repository: "{ org }/{ repo }" # ${{ github.repository }} | |||
There was a problem hiding this comment.
As I mentioned in VersionTagChecker project, this comment is little confusing. I see that the number below is the number of github.event. But for repository, I don't think it is true. It should be repository.login.owner and repository.login.name or something like it. OR it is same as repository.id.
| yield mock_log_config | ||
|
|
||
| @pytest.fixture() | ||
| def mock_exit(code) -> list: |
There was a problem hiding this comment.
Keep the same pattern of having or not having the method docstrings.
MobiTikula
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: