ci: Run wheel workflow on certain pushes #4617
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only running the wheel workflow on pushes of TAGS, but this change also will run it when we push to release, and dev-3.* branches. My usual release workflow is that to first push the "release" branch, watch for it to pass CI, then add the tag and push the tag and draft the release. If a problem with the wheel workflow isn't discovered until we've already pushed the tag, then a fix will require a new tag and new release (we never re-tag a release). So this change will allow us to catch any problems with the wheel worflow BEFORE we actually irrevocably make the tag, since it's no big deal to add corrections to the branch before tagging. It still won't upload the wheels until the tag itself is pushed. Signed-off-by: Larry Gritz <[email protected]>
|
@zachlewis This sound good to you? |
|
Oh, most certainly. This makes a lot of sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only running the wheel workflow on pushes of TAGS, but this change also will run it when we push to release, and dev-3.* branches.
My usual release workflow is to first push the "release" branch, watch for it to pass CI, then add the tag and push the tag and draft the release. If a problem with the wheel workflow isn't discovered until we've already pushed the tag, then a fix will require a new tag and new release (we never re-tag a release). So this change will allow us to catch any problems with the wheel worflow BEFORE we actually irrevocably make the tag, since it's no big deal to add corrections to the branch before tagging. It still won't upload the wheels until the tag itself is pushed.