api(span.h): Only allow span-from-array if array for compatible size #4656
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From an array of known size, we can implicitly construct a span of dynamic length, or of fixed length equal to the array length. Use template enable_if trick to restrict to these cases. Previously, the constructor would have allowed a fixed-length span to be constructted from an array of differing length, which should obviously have been disallowed. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From an array of known size, we can implicitly construct a span of dynamic length, or of fixed length equal to the array length. Use template enable_if trick to restrict to these cases.
Previously, the constructor would have allowed a fixed-length span to be constructed from an array of differing length, which should obviously have been disallowed.