Code cleanup

.luacheckrc

@@ -0,0 +1,4 @@
+globals = {'LibStub', 'UIDROPDOWNMENU_OPEN_PATCH_VERSION', 'UIDROPDOWNMENU_OPEN_MENU', 'COMMUNITY_UIDD_REFRESH_PATCH_VERSION', 'COMMUNITY_UIDD_REFRESH_PATCH_VERSION', 'RAID_CLASS_COLORS', 'LOCALIZED_CLASS_NAMES_MALE', 'CLASS_ICON_TCOORDS', 'ALL', 'ARENA_2V2', 'ARENA_3V3', 'BATTLEGROUND_10V10', 'MAX_CLASSES', 'BATTLEGROUND', 'AUCTION_DURATION', 'DAMAGE', 'WIN', 'SHOW_COMBAT_HEALING', 'HONOR', 'RATING', 'TEAM', 'ENEMY', 'ARENA', 'hooksecurefunc', 'issecurevariable', 'FriendsFrame', 'FriendsTabHeader'}
+ignore = {'self', '532'}
+max_line_length = false
+self = false

.pkgmeta

@@ -17,6 +17,7 @@ externals:
 
 ignore:
   - README.md
+  - .luacheckrc
   - Libs/LibToast-1.0/LibStub
   - Libs/LibToast-1.0/LibToast-1.0.toc
   - Libs/LibToast-1.0/lib.xml

ElvUI.lua

@@ -1,8 +1,8 @@
 local _G = _G
 local unpack = _G.unpack
 
-if not AddOnSkins then return end
-local AS = unpack(AddOnSkins)
+if not _G.AddOnSkins then return end
+local AS = unpack(_G.AddOnSkins)
 if not AS:CheckAddOn("REFlex") then return end
 
 function AS:REFlex()

LICENSE.txt

@@ -1,2 +1,2 @@
 All Rights Reserved unless otherwise explicitly stated.
-Copyright (c) 2013-2018 Paweł Jastrzębski <[email protected]>
+Copyright (c) 2013-2019 Paweł Jastrzębski <[email protected]>

README.md

@@ -8,4 +8,4 @@
 
 All Rights Reserved unless otherwise explicitly stated.
 
-Copyright (c) 2013-2018 Paweł Jastrzębski <[email protected]>
+Copyright (c) 2013-2019 Paweł Jastrzębski <[email protected]>

REFlex.lua

@@ -53,7 +53,6 @@ if (COMMUNITY_UIDD_REFRESH_PATCH_VERSION or 0) < 1 then
 	end)
 end
 
---GLOBALS: UIDROPDOWNMENU_VALUE_PATCH_VERSION, UIDROPDOWNMENU_MAXLEVELS, UIDROPDOWNMENU_MAXBUTTONS, UIDROPDOWNMENU_OPEN_PATCH_VERSION, UIDROPDOWNMENU_OPEN_MENU, issecurevariable
 local tinsert = _G.table.insert
 local mfloor = _G.math.floor
 local strmatch = _G.string.match
@@ -576,7 +575,7 @@ function RE:OnEnterTooltip(cellFrame, databaseID)
 				RE.TooltipRGB1:SetBackdropColor(red, green, blue, ElvUI[1].Tooltip and ElvUI[1].Tooltip.db.colorAlpha or 1)
 			end
 			RE.TooltipRGB1:Show()
-			local team, damageSum, healingSum, kbSum = RE:GetRGBTeamDetails(databaseID, false)
+			team, damageSum, healingSum, kbSum = RE:GetRGBTeamDetails(databaseID, false)
 			RE.TooltipRGB2 = QTIP:Acquire("REFlexTooltipRGB2", 7, "CENTER", "CENTER", "CENTER", "CENTER", "CENTER", "CENTER", "CENTER")
 			RE.TooltipRGB2:AddLine()
 			for i=1, 7 do

REFlexFunctions.lua

@@ -6,7 +6,6 @@ local DUMP = LibStub("LibTextDump-1.0")
 local TOAST = LibStub("LibToast-1.0")
 local ST = LibStub("ScrollingTable")
 
---GLOBALS: CLASS_ICON_TCOORDS, RAID_CLASS_COLORS, LOCALIZED_CLASS_NAMES_MALE
 local tinsert, tsort, tconcat, tremove = _G.table.insert, _G.table.sort, _G.table.concat, _G.table.remove
 local mfloor = _G.math.floor
 local sgsub, sbyte = _G.string.gsub, _G.string.byte