Work around PyQt memory leak on the Krita::documents() method. #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeepingCreature
force-pushed
the
fix/work-around-memleak
branch
6 times, most recently
from
30ffe9d to
0245fff
Compare
FeepingCreature
force-pushed
the
fix/work-around-memleak
branch
from
0245fff to
d435ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documents()is specified asQList<Document *> documents() const /Factory/;inKrita.sip. This means that theQListis cleaned up (/Factory/), but asDocument*is very generic SIP has no idea what to do with them and they just leak.