Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed incorrectly referenced ts module in new settings popup #155

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jjcastro
Copy link
Contributor

@jjcastro jjcastro commented Feb 9, 2025

I noticed the popup wasn't working after I cloned, built and installed the extension afresh after #154 - settings/main.ts wasn't being built when using make build-chrome.


Important

Fixes script loading issue in index.html by changing source from main.js to main.ts.

  • Behavior:
    • Fixes issue where settings/main.ts was not being built when using make build-chrome.
    • Changes script source in index.html from main.js to main.ts to ensure correct module loading.

This description was created by Ellipsis for 555e0a9. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 555e0a9 in 56 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. src/settings/index.html:40
  • Draft comment:
    Referencing a TypeScript file directly is unusual since browsers don't natively support TS. Ensure your build process transpiles main.ts to JS for deployment.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
    While browsers don't natively run .ts files, modern build setups often use tools like Vite that can handle TypeScript files directly in development. The type="module" attribute suggests this is a modern setup. Without seeing the build configuration, we can't assume this is incorrect.
    I might be making assumptions about the build setup. The comment could be raising a valid concern about production deployment.
    However, the comment violates our rules - it's asking to "ensure" something about the build process, which is both speculative and outside the scope of this file review.
    Delete the comment as it's speculative, asks for verification, and requires knowledge of the build setup that we don't have.
2. src/settings/index.html:40
  • Draft comment:
    Referencing a .ts file directly in the script tag may cause runtime errors. Typically, the build process should output a compiled .js file, which the HTML should then load.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_Ddyqrlf2G2AItaPU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@BelKed
Copy link
Contributor

BelKed commented Feb 9, 2025

Ohh... Great catch 🔥
I guess I forgot to test it in Chrome 🫣

@cweiske
Copy link

cweiske commented Feb 9, 2025

I also had this problem in #156, but with firefox.

Copy link
Contributor

@BelKed BelKed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks! :)

@ErikBjare ErikBjare changed the title Fix new settings popup not building js fix: fixed incorrectly referenced ts module in new settings popup Feb 11, 2025
@ErikBjare ErikBjare merged commit 1cbe84c into ActivityWatch:master Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants