sammi-jo's HOTBOOK (nodes) #28

sjlee3157 · 2018-09-10T12:24:06Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	For a while, I wanted to pursue making a Reservation class that could store all instances of reservations and had self.all and self.find (etc.) methods -- to make it more independent from the Book class, and to apply a concept from class that I felt hazy and curious about to gain more mastery of it. However, I ultimately decided that the cost of learning how to do that, and the trial and error it would require, wasn't worth it for this project, so I stuck with a model more similar to ride-share-oo that I knew I knew how to do.
Describe a concept that you gained more clarity on as you worked on this assignment.	I am much more comfortable with MiniTest, and using MiniTest together with pry, than I was before this project. It took some experimenting to get the hang of what information is created and destroyed at what points when the spec file is running.
Describe a nominal test that you wrote for this assignment.	book.new_reservation() assigns the first available room number for the date range, creates an instance of the Reservation class, and adds the new instance to an instance variable array.
Describe an edge case test that you wrote for this assignment.	Booking the same new reservation 21 times, however, returns an error, because all 20 rooms in the hotel will have been assigned already.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	At the beginning, I felt like I was losing much more time by writing tests than it was worth to have created a test file that could live with the code and run with it. It was very, very slow going to write tests at first, until I got the hang of setting up tests. By Wave 3, I had some more flow in writing tests, and test writing + pseudocode became more like one process. That's because I could write tests more naturally, almost like rubber ducking out loud about what my code should do, integrating the test writing in to my coding process.

…ion method, tests pass

…method is written

…onflict?(daterange) Pick one, and update both the class method and the method in book.rb that depends on it.

CheezItMan · 2018-09-13T04:21:19Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits and good commit messages
Answer comprehension questions	Check
Design
Each class is responsible for a single piece of the program	Yes, although you have an extraneous class that's not doing very much.
Classes are loosely coupled	Check
Wave 1
List rooms	Check
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check
Test coverage	100%
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	Check
Test coverage	100%
Wave 3
Create a block of rooms	Check, although it's requiring the user to specify the rooms in the block.
Check if a block has rooms	Check
Reserve a room from a block	Check
Test coverage	100%
Fundamentals
Names variables, classes and modules appropriately	You need to work on your class names a bit. Some of the names like `Hotel` and `Book` are unclear in what they do
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	Check
Appropriately uses methods to break down tasks into smaller simpler tasks	Check, well done in building small specific methods.
Understands the differences between class and instance methods	Check, no class variables (good job!), and a few useful class methods.
Appropriately uses iterators and enumerables	Well done
Appropriately writes and utilizes classes	check
Appropriately utilizes modules as a mechanism to encapsulate functionality	Check
Wrap Up
There is a refactors.txt file	Check
The file provides a roadmap to future changes	Well done, very well laid out
Additional Feedback	Well done, you did a good job with the design and write fairly efficient code. Very nice work here.

CheezItMan · 2018-09-12T22:18:30Z

lib/book.rb

+      end
+      # Cannot overlap or conflict with existing reservation
+      rooms.each do |room_number|
+        if room_taken?(daterange, room_number)


This will break if ONE room is unavailable in the date range.

Correction
Normally when you're reserving a block of rooms you specify the number and the system picks the rooms. The front Desk doesn't have to individually select them.

When we met, I missed the fact that you're passing in the list of rooms to include in the block as a parameter. I just hadn't consider it at that moment. So your code works, but with a limitation that the user has to specify every room to include in the block, rather than just selecting a group from the available rooms.

CheezItMan · 2018-09-13T03:53:18Z

hotbook.rb

@@ -0,0 +1,24 @@
+# gems the project needs


This file's a neat idea!

CheezItMan · 2018-09-13T03:55:14Z

lib/block.rb

+      @available = rooms.clone
+      @room_rate = room_rate
+    end
+


So Block has a set of rooms and a way to remove rooms from the list, and tell if the block conflicts, I feel like it should be able to reserve a room in the block as well, maybe then returning a reservation which your booking system could use to update reservations.

CheezItMan · 2018-09-13T03:56:02Z

lib/book.rb

+# making new reservations and blocks.
+# It includes support methods for determining availability/conflicts.
+
+  class Book


Maybe a better name is BookingManager. Book sounds like I should be able to turn pages and get an author.

CheezItMan · 2018-09-13T03:56:41Z

lib/book.rb

+    attr_reader :reservations, :hotel, :blocks
+
+    def initialize(hotel) # expects a dependency injection (HotBook::Hotel.new)
+      @hotel = hotel


What is the@hotel variable supposed to do?

CheezItMan · 2018-09-13T04:08:34Z

spec/block_spec.rb

+
+  describe "disable method" do
+    it "won't alter the rooms array when it executes" do
+      block.disable("1")


Maybe check that it contained 1 before and then it doesn't after.

CheezItMan · 2018-09-13T04:09:22Z

spec/block_spec.rb

+    end
+  end
+
+  describe "conflict? method" do


You should test more varieties of conflicts.

CheezItMan · 2018-09-13T04:10:06Z

spec/block_spec.rb

+  describe "disable method" do
+    it "won't alter the rooms array when it executes" do
+      block.disable("1")
+      expect(block.available).must_equal ["2", "3"]


Also what happens if you try to disable a room twice?

CheezItMan · 2018-09-13T04:10:39Z

spec/book_spec.rb

+    end
+
+    it "new reservation edge case" do
+      expect{ 21.times { book.new_reservation(shortrange) } }.must_raise HotBook::NoRoomsAvailableError


CheezItMan · 2018-09-13T04:24:25Z

spec/book_spec.rb

+      expect{book.new_block(daterange, rooms)}.must_raise HotBook::BlockConflictError
+    end
+
+    it "cannot overlap or conflict with an existing reservation" do


sjlee3157 added 30 commits September 4, 2018 12:28

Added class files, spec files, spec helper, and Guardfile for envi setup

9ae2d21

Added reservation.rb and spec

c619148

Updated Wave1 lib file setup

b43773d

Updated Wave1 spec files setup

a22d58f

Added pseudocode.md for code design

d285e3b

Wave1 hotel_spec tests written

d5a339d

Wave1 hotel_spec tests written

57b76b1

Merge branch 'master' of https://github.com/sjlee3157/hotel

91403fd

Hotel class passes specs

e095f19

Hotel class passes specs

1fe9023

Deleted loader class and spec

792761a

Added DateRange class

ea85f45

Finished DateRange class & spec for Wave 1, tests pass

00e2798

Added to_range method in DateRange, test passes

2043e50

Good chunk of design refactors for Wave 1

b7ef34b

Nvm - don't need daterange.to_range

fcc08ba

Wave 1 Reservation class done, tests passing

d4da006

Updates to DateRange- specs passing, 100% cov

1a71d74

Wave1 Book class complete, tests pass

336113a

Wave1 Hotel class done, tests pass.

c4ca4d0

Added data/ and room_numbers.csv

163211e

Hotel now loads CSV file of room numbers, tests pass

9c00164

Added support folder for test data files

198151f

Added private save_reservation method to Res class, tests pass

210d953

Added conflict? method in DateRange, tests pass

659cc3f

Merge branch 'master' of https://github.com/sjlee3157/hotel

a271409

Created list_avail_rooms method in Book, tests pass, support data added

7106eff

Added suggested room and error checking functionality to new reservat…

4790fbe

…ion method, tests pass

Tests passing for Wave 2 requirements

a2b717b

Added empty files for new Block class

007fc01

sjlee3157 added 24 commits September 9, 2018 17:51

Fixed mistake in to_range method--should be exclusive

1063289

Hotel.find_rate class method still needs to be tested after CSV load …

a8e62c0

…method is written

Ready to work on and test block methods in book.rb

c74aac3

Added code to load reservations from CSV, not yet tested

dbb6b69

Better comments explaining range as overnights

b00e918

Added CSV loading method, tests pass

25a7649

Daterange now has conflict? method of its own

2157e3b

Reservation range bug fixed - no longer includes checkout date

712d117

private validate method checks all arguments

6ec25ee

modified test reservation data

f2868ab

Added custom errors in errors.rb to HotBook module

b5fa688

Book class can now identify reservation and block conflicts

20e9c2f

Added hotbook.rb file

f7efff1

Book class can make new block and check for conflicts

65c20ba

Book class can make new block reservations and check for conflicts

f81e93b

all current specs passing and 100% coverage

fa642ea

Tested many new edge cases in Book.rb

097f6b7

Deleted pseudocode.rb

d9b0806

Notes added to refactors.txt

9249d5f

Added new reservation nominal case in book sepc

6addaa5

Deleted pseudocode.md

cf6fff8

Notes added to refactors.txt

2ac71d8

Added new reservation nominal case in book sepc

2f55f2d

Tagged a todo - inconsistency: daterange.conflict?(other) vs. block.c…

3959abe

…onflict?(daterange) Pick one, and update both the class method and the method in book.rb that depends on it.

CheezItMan reviewed Sep 13, 2018

View reviewed changes

sjlee3157 added 4 commits September 29, 2018 20:14

Renamed Book class to BookingsManager

ed6bead

Merge branch 'master' of https://github.com/sjlee3157/hotel

379c1f2

Added new items to refactors list

64be846

Added design-activity.md

c884592

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sammi-jo's HOTBOOK (nodes) #28

sammi-jo's HOTBOOK (nodes) #28

sjlee3157 commented Sep 10, 2018 •

edited

Loading

CheezItMan commented Sep 13, 2018 •

edited

Loading

CheezItMan Sep 12, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

CheezItMan Sep 13, 2018

sammi-jo's HOTBOOK (nodes) #28

Are you sure you want to change the base?

sammi-jo's HOTBOOK (nodes) #28

Conversation

sjlee3157 commented Sep 10, 2018 • edited Loading

Hotel

Comprehension Questions

CheezItMan commented Sep 13, 2018 • edited Loading

Hotel

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjlee3157 commented Sep 10, 2018 •

edited

Loading

CheezItMan commented Sep 13, 2018 •

edited

Loading