Carly - Edges - Reverse_sentence algorithm. #13
Conversation
| end | ||
|
|
||
| length = my_sentence.length | ||
| i = 0 |
There was a problem hiding this comment.
You could consider calling the string_reverse method you created above passing in start_index as 0 and end_index as length-1. That way, you'll avoid code repetition.
| end | ||
| end_index = i - 1 | ||
|
|
||
| reversed_string = string_reverse(my_words, start_index, end_index) |
There was a problem hiding this comment.
Given that all the string manipulations are happening in-place in this file, you don't need to return anything from the methods or assign anything. e.g. lines 43 could simply be string_reverse(my_words, start_index, end_index) and line 46 can simply be return. The same applies to all other methods.
|
Nice work! I added some comments inline for further improvements. I also didn't see any comments on the time and space complexities. Take a look at another similar solution and the time and space complexity here: https://github.com/Ada-C10/reverse_sentence/blob/solution/lib/reverse_sentence.rb |
Once I actually understood the reverse_words (thanks for providing the solution - much help!), this alogorithm came quite easily to me.