Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layla & Pushpa - Edges - Rideshare Rails #10

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

lbristol88
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way A driver has many trips, a passenger has many trips, and each trip has one driver and one passenger. It is a one to many relationship.
Describe the role of model validations in your application We define how each model relates to each other, with the attributes of has_many and belongs_to. We also include the validation of what each model must contain, such as a each driver must have a name and a vin.
How did your team break up the work to be done? We worked closely together throughout the project and practiced the driver and navigator technique when we were working together in person. We divided up individual tasks through the trello board for when we were out of the office.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized CRUD operations, followed through each user story and requirement and left the styling for last if time permitted.
What was one thing that your team collectively gained more clarity on after completing this assignment? We had a better understanding about the total MVC process and how each component relates to each other.
What is your Trello board URL? https://trello.com/b/4gax1EXt/layla-pushpa-rideshare
What is the Heroku URL of your deployed application? https://ada-rideshare-rails.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We enjoyed working together on this project. Most groups divided up the tasks, but in order to solidify our understanding of the learning goals, we spent a lot of time doing each task together during project time. There were a couple things that we completed individually at home, but we made sure to review each aspect with the other person once we met in person.

lbristol88 and others added 30 commits October 1, 2018 15:54
…or page that explains why they can't delete the passenger or dirver
@lbristol88 lbristol88 changed the title Layla & Pushpa - Edges - Ridesharerails Layla & Pushpa - Edges - Rideshare Rails Oct 5, 2018
@droberts-sea
Copy link

Rideshare Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate git usage with no extraneous files checked in and both partners contributing yes
Answered comprehension questions yes
Uses named routes (like _path) yes
RESTful routes utilized yes
Project Requirements
Table relationships yes
Validation rules for Models yes
Business logic is in the models yes
Database is seeded from the CSV files yes
Trello board is created and utilized in project management yes
Heroku instance is online yes
The app is styled to create an attractive user interface yes
Overall Good work overall! You make good use of validations and relations, and most of your business logic is in the model - it's clear to me that most of the learning goals for this week were met (with the one exception of nested routes). As with any project of this size I've left a number of nitpicks, but in general I am happy with what I see here. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants