-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amy M #15
base: master
Are you sure you want to change the base?
Amy M #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at my notes on Newman Conway. You aren't applying a dynamic programming approach. Review the textbook curriculum and let me know what questions you have.
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n) | ||
# Space Complexity: O(1) | ||
def max_sub_array(nums) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
def newman_recursive(n) | ||
return 1 if n <= 2 | ||
return newman_recursive(newman_recursive(n - 1)) + newman_recursive(n - newman_recursive(n - 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the fibonacci notes in the textbook curriculum on algorithms. This is the same approach as the default recursive solution. Because you're not doing dynamic programming here (solving and saving subproblems for use later), you end up solving the same problems over and over again. This is actually O(33)
@@ -1,7 +1,21 @@ | |||
|
|||
|
|||
# Time complexity: ? | |||
# Space Complexity: ? | |||
# Time complexity: O(n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎 😭
No description provided.