Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amy M #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Amy M #15

wants to merge 2 commits into from

Conversation

amyesh
Copy link

@amyesh amyesh commented Oct 8, 2019

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at my notes on Newman Conway. You aren't applying a dynamic programming approach. Review the textbook curriculum and let me know what questions you have.

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def max_sub_array(nums)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

def newman_recursive(n)
return 1 if n <= 2
return newman_recursive(newman_recursive(n - 1)) + newman_recursive(n - newman_recursive(n - 1))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the fibonacci notes in the textbook curriculum on algorithms. This is the same approach as the default recursive solution. Because you're not doing dynamic programming here (solving and saving subproblems for use later), you end up solving the same problems over and over again. This is actually O(33)

@@ -1,7 +1,21 @@


# Time complexity: ?
# Space Complexity: ?
# Time complexity: O(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants