-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shubha 🧟♀️ #19
base: master
Are you sure you want to change the base?
Shubha 🧟♀️ #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, you fully applied dynamic programming to these solutions. Well done!
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n) | ||
# Space Complexity: O(1) | ||
def max_sub_array(nums) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
return nil if nums == nil || nums.empty? | ||
max = nums[0] | ||
curr_max = nums[0] | ||
(1...nums.length).each do |i| | ||
curr_max = curr_max + nums[i] | ||
if nums[i] > curr_max | ||
max = nums[i] if nums[i] > max | ||
curr_max = nums[i] | ||
else | ||
max = curr_max if curr_max > max | ||
end | ||
end | ||
return max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very elegantly done
# Time complexity: ? | ||
# Space Complexity: ? | ||
# Time complexity: O(n) | ||
# Space Complexity: O(n) | ||
def newman_conway(num) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
seq = [0, 1, 1] | ||
raise ArgumentError if num <= 0 | ||
return seq[1..num].join(' ')if num == 1 || num == 2 | ||
(3..num).each do |i| | ||
seq[i] = seq[seq[i-1]] + seq[i - seq[i - 1]] | ||
end | ||
return seq[1..num].join(' ') | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
No description provided.