Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Shirley #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lib/factorial.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n), where n represents the number. The while loop runs n - 1 times, so the time complexity does depend on n.
# Space complexity: Constant. Regardless of how big the number is, there are only two variables inside the method.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanations!

def factorial(number)
raise NotImplementedError
raise ArgumentError unless number
factorial = 1
while number > 1
factorial *= number
number -= 1
end
return factorial

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear code, nice job. 👍

end