Ports-Elise #3
Open
Ports-Elise #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Aug 20, 2019
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) | ||
| temp_node = @head |
| # Space Complexity: O(1) | ||
| def find_max | ||
| if @head == nil | ||
| return @head |
| # Space Complexity: O(1) | ||
| def length | ||
| length = 0 | ||
| if @head == nil |
| # method to delete the first node found with specified value | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
| # returns the value at the middle element in the singly linked list | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_middle_value |
There was a problem hiding this comment.
Nicely done, you didn't even use length!
|
|
||
| temp_node = @head | ||
| idx = 0 | ||
| while temp_node != nil |
There was a problem hiding this comment.
You could also use the method to get at an index here.
| # returns true if a cycle is found, false otherwise. | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def has_cycle |
| # method that inserts a given value as a new last node in the linked list | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_last(value) |
There was a problem hiding this comment.
Would adding an instance variable @tail which refers to the last node in a linked list make this method easier or more efficient?
| def add_last(value) | ||
| raise NotImplementedError | ||
| temp_node = @head | ||
| while temp_node != nil |
There was a problem hiding this comment.
With these types of loops could you instead do until temp_node.next.nil?
| # list is sorted in ascending order | ||
| # Time Complexity: | ||
| # Space Complexity | ||
| def insert_ascending(value) |
There was a problem hiding this comment.
What about if you inserted a node which was less than the head of a long list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.