Margaret #5
Open
Margaret #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 3, 2019
| @@ -6,158 +6,294 @@ class Node | |||
|
|
|||
| def initialize(value, next_node = nil) | |||
| @data = value | |||
| @next = next_node | |||
| @next = nil | |||
| def add_first(value) | ||
| new_node = Node.new(value) | ||
|
|
||
| if @head != nil #if list isn't empty |
There was a problem hiding this comment.
Even if @head is nil, wouldn't the line below still work?
| def search(value) | ||
| raise NotImplementedError | ||
| current = @head | ||
| while @next != nil |
There was a problem hiding this comment.
Don't you mean while current != nil, and you should be doing current = current.next
| # note: the nodes should be moved and not just the values in the nodes | ||
| # Time Complexity: 0(n) where n is length of linked list bc we are checking each node | ||
| # Space Complexity: constant, extra space needed for variables does not grow as the size of the LL grows | ||
| def reverse |
| # Time Complexity: | ||
| # Space Complexity | ||
| def find_nth_from_end(n) | ||
| #copied from solution branch so tests for reverse could run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.