Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Grace #29

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Sockets - Grace #29

wants to merge 15 commits into from

Conversation

gracemshea
Copy link

@gracemshea gracemshea commented Apr 8, 2019

Personal Portfolio Site

Congratulations! You're submitting your assignment!

-Will answer these questions throughout the morning

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I got several warning about section lacking headings and issue with the google fonts link provided on the google fonts website. I am refactoring to include headers, not sure how to resolve font issue.
Why is it important to consider and use semantic HTML? Many accessibility tools like screen readers rely on semantic HTML to navigate through a webpage.
How did you decide to structure your CSS? I created a main.css which set up the features I wanted on each site, like the background, colors, font, and nav formatting. I created additional css files to format each individual page with further specificity.
What was the most challenging piece of this assignment? I think the time frame. I did use placeholder images and lorem ipsum because I didn't get to some areas. I will continue to refine this project.
Describe one area that you gained more clarity on when completing this assignment My knowledge of HTML and CSS was minimal before this project/week's curriculum. I think the most useful knowledge was how to create layout and how to make certain effects like hover, etc that can make a site look more professional.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? N/A

p.s. I realize I need to redesign the About page since the image/text overlay didn't work out well visually.

@gracemshea gracemshea marked this pull request as ready for review April 15, 2019 00:51
@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling almost - "about" is a little empty
HTML
Uses the high-level tags for organization: header, footer, main some - the high level structure of your pages is inconsistent, some are missing these tags
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Great work overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants