Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets- Cyndi #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets- Cyndi #34

wants to merge 1 commit into from

Conversation

cyndilopez
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Forgot the attr for images.
Why is it important to consider and use semantic HTML? It made it easier to later read and interpret my html and css files.
How did you decide to structure your CSS? I made a general styles CSS page for all pages, and made individual pages for each component of my website. In each page, I structured it so that I was formatting top-down from the page.
What was the most challenging piece of this assignment? Getting it done on time. There was too little time assigned to do this.
Describe one area that you gained more clarity on when completing this assignment Pseudo-elements became more clear to me.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? Not yet

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage It looks like you lost this history due to forgetting to fork. Make sure you're following the same add/commit process for HTML as for any other code.
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes - this varies a lot between pages. It would be worthwhile to make this consistent - that will make your styling work easier.
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Good work overall. I don't see a ton of work with flexbox and grid here, so make sure you're taking the opportunity to practice that on our various Rails projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants