Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Ngoc #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,34 @@ import './App.css';
import timelineData from './data/timeline.json';

import Timeline from './components/Timeline';
import TimelineEvent from './components/TimelineEvent';

class App extends Component {
render() {
console.log(timelineData);

const timelineComponent = timelineData["events"].map((post,i) => {
return (
<li key={i}>
<TimelineEvent
person={post.person}
timeStamp={post.timeStamp}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation for the JSON file

status={post.status}
/>
</li>
)
}
)
const data = timelineData["events"]
// Customize the code below
return (
<div className="App">
<header className="App-header">
<h1 className="App-title">Application title</h1>
<h1 className="App-title">Ada's Social Media Feed</h1>
</header>
<main className="App-main">
<ul>
{timelineComponent}
</ul>
</main>
</div>
);
Expand Down
13 changes: 10 additions & 3 deletions src/components/Timeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@ import React from 'react';
import './Timeline.css';
import TimelineEvent from './TimelineEvent';

const Timeline = () => {
// Fill in your code here
return;
const Timeline = (props) => {
return (
<section>
<h4>
{props.person}
</h4>
<p> {props.timeStamp}</p>
<p> {props.status}</p>
</section>
);
}

export default Timeline;
18 changes: 15 additions & 3 deletions src/components/TimelineEvent.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,21 @@ import React from 'react';
import './TimelineEvent.css';
import Timestamp from './Timestamp';

const TimelineEvent = () => {
// Fill in your code here
return;
const TimelineEvent = (props) => {

return (
<section>
<h4>
{props.person}
</h4>
<p>
<Timestamp
time={props.timeStamp}
/>
</p>
<p> {props.status}</p>
</section>
);
}

export default TimelineEvent;
2 changes: 1 addition & 1 deletion src/components/Timestamp.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import moment from 'moment';

const Timestamp = (props) => {
const time = moment(props.time);
const time = moment(props);
const absolute = time.format('MMMM Do YYYY, h:mm:ss a');
const relative = time.fromNow();

Expand Down